On Sat, 3 Nov 2012 16:35:02 +0900
Isaku Yamahata <[email protected]> wrote:
> > diff --git a/ryu/contrib/ovs/poller.py b/ryu/contrib/ovs/poller.py
> > index c04c9b3..03082d3 100644
> > --- a/ryu/contrib/ovs/poller.py
> > +++ b/ryu/contrib/ovs/poller.py
> > @@ -20,6 +20,11 @@ import socket
> >
> > vlog = ovs.vlog.Vlog("poller")
> >
> > +POLLIN = 0x001
> > +POLLOUT = 0x004
> > +POLLERR = 0x008
> > +POLLHUP = 0x010
> > +POLLNVAL = 0x020
>
> If monkey patching is allowed, how about this?
> With this, we don't have to s/select.POLLxxx/ovs.pollar.xxx/g
>
> if not hasatter(select, 'POLLIN'):
> select.POLLIN = 0x001
> ...
Either is fine by me. IIRC, your initial patch to do monkey patch for
ovs python binding select stuff was rejected by OVS maintainer so I
did in the straight way (and I don't like monkey patch trick in
general). I'm not sure if it's worth fixing this problem in upstream
though.
------------------------------------------------------------------------------
LogMeIn Central: Instant, anywhere, Remote PC access and management.
Stay in control, update software, and manage PCs from one command center
Diagnose problems and improve visibility into emerging IT issues
Automate, monitor and manage. Do more in less time with Central
http://p.sf.net/sfu/logmein12331_d2d
_______________________________________________
Ryu-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ryu-devel
