Hi. Thank you for report. The patch looks correct. Can you please send the patch with your signed-off-by to this ML?
thanks, On Wed, Jan 09, 2013 at 04:41:07PM -0800, Shivaram Mysore wrote: > Hello, > > I am running a simple flow learning application and I get the below error. I > have a feeling that the fix as noted in > https://github.com/rpt/ryu/commit/ebf7638aac4481762e10ec90958f1480761a3893 > could help resolve this issue: > > ryu/ofproto/ofproto_v1_3_parser.py > > ・ View file @ ebf7638 > > ... ... @@ -1413,7 +1413,7 @@ def parser(cls, datapath, version, msg_type, > msg_len, xid, buf): > > 1413 1413 > > 1414 1414 @_set_msg_type(ofproto_v1_3.OFPT_PACKET_OUT) > > 1415 1415 class OFPPacketOut(MsgBase): > > 1416 - def __init__(self, datapath, buffer_id=None, inport=None, > actions=None, > > 1416 + def __init__(self, datapath, buffer_id=None, in_port=None, > actions=None, > > 1417 1417 data=None): > > 1418 1418 assert in_port is not None > > > > Actual Error: > > instantiating app ryu.controller.ofp_handler > connected socket:<socket fileno=4 sock=127.0.0.1:6633 peer=127.0.0.1:44083> > address:('127.0.0.1', 44083) > hello ev <ryu.controller.ofp_event.EventOFPHello object at 0x17d4650> > move onto config mode > switch features ev version: 0x4 msg_type 0x6 xid 0x73ae64f4 > move onto main mode > installing new source mac received from port 2 > Traceback (most recent call last): > File > "/usr/local/lib/python2.7/site-packages/ryu-1.5-py2.7.egg/ryu/controller > /controller.py", line 94, in deactivate > method(self) > File > "/usr/local/lib/python2.7/site-packages/ryu-1.5-py2.7.egg/ryu/controller > /controller.py", line 172, in _recv_loop > self.ev_q.queue(ofp_event.ofp_msg_to_ev(msg)) > File > "/usr/local/lib/python2.7/site-packages/ryu-1.5-py2.7.egg/ryu/controller > /dispatcher.py", line 109, in queue > self._dispatcher(ev) > File > "/usr/local/lib/python2.7/site-packages/ryu-1.5-py2.7.egg/ryu/controller > /dispatcher.py", line 174, in __call__ > self.dispatch(ev) > File > "/usr/local/lib/python2.7/site-packages/ryu-1.5-py2.7.egg/ryu/controller > /dispatcher.py", line 191, in dispatch > handled = self._dispatch(ev, self.events.get(ev.__class__, [])) > File > "/usr/local/lib/python2.7/site-packages/ryu-1.5-py2.7.egg/ryu/controller > /dispatcher.py", line 182, in _dispatch > ret = h(ev) > File "/usr/local/src/linc/linc_ryu_apps/l2_switch_v1_3.py", line 78, in > _packet_in_handler > self.flood(datapath, msg.data) > File "/usr/local/src/linc/linc_ryu_apps/l2_switch_v1_3.py", line 107, in > flood > [output_all], data) > File "/usr/local/lib/python2.7/site-packages/ryu-1.5-py2.7.egg/ryu/ofproto/ > ofproto_v1_3_parser.py", line 1418, in __init__ > assert in_port is not None > NameError: global name 'in_port' is not defined > Error in the datapath 40808612191141888 from ('127.0.0.1', 44083) > Traceback (most recent call last): > File "/usr/local/lib/python2.7/site-packages/ > gevent-0.13.8-py2.7-linux-x86_64.egg/gevent/greenlet.py", line 390, in run > result = self._run(*self.args, **self.kwargs) > File > "/usr/local/lib/python2.7/site-packages/ryu-1.5-py2.7.egg/ryu/controller > /controller.py", line 298, in datapath_connection_factory > datapath.serve() > File > "/usr/local/lib/python2.7/site-packages/ryu-1.5-py2.7.egg/ryu/controller > /controller.py", line 217, in serve > self._recv_loop() > File > "/usr/local/lib/python2.7/site-packages/ryu-1.5-py2.7.egg/ryu/controller > /controller.py", line 94, in deactivate > method(self) > File > "/usr/local/lib/python2.7/site-packages/ryu-1.5-py2.7.egg/ryu/controller > /controller.py", line 172, in _recv_loop > self.ev_q.queue(ofp_event.ofp_msg_to_ev(msg)) > File > "/usr/local/lib/python2.7/site-packages/ryu-1.5-py2.7.egg/ryu/controller > /dispatcher.py", line 109, in queue > self._dispatcher(ev) > File > "/usr/local/lib/python2.7/site-packages/ryu-1.5-py2.7.egg/ryu/controller > /dispatcher.py", line 174, in __call__ > self.dispatch(ev) > File > "/usr/local/lib/python2.7/site-packages/ryu-1.5-py2.7.egg/ryu/controller > /dispatcher.py", line 191, in dispatch > handled = self._dispatch(ev, self.events.get(ev. > > > > > ------------------------------------------------------------------------------ > Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, > MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current > with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft > MVPs and experts. ON SALE this month only -- learn more at: > http://p.sf.net/sfu/learnmore_122712 > _______________________________________________ > Ryu-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/ryu-devel -- yamahata ------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at: http://p.sf.net/sfu/learnmore_122712 _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
