On Tue, Jan 29, 2013 at 05:20:16PM -0800, Marcelo Nascimento wrote:
> Hi,

Hi.


> I think I've found a bug in RYU.
> What happens is that datapath_join event is fired before datapath object is
> inserted into the list in DPSet.
> So when I try to get the datapath through dpset.get(dpid) from my 
> datapath_join
> handler, it returns None.

The patch looks correct. It's ambiguous now if dpset include (or not include)
the given dpid when dp enter/leave event is being handled.
So let's document it as python doc to the register/unregister method.

- On dp enter event
  dpset includes the corresponding dp

- On dp leave event
  dpset doesn't include the corresponding dp
  (the OF connection is already closed.)


BTW in your handler for dp enter event, you already have EventDP.dp.
So you don't have to call dpset.get(dpid) again.


> Please find the patch attached.

Please add your signed-off-by.
-- 
yamahata

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_jan
_______________________________________________
Ryu-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ryu-devel

Reply via email to