On Wed, 06 Feb 2013 12:56:04 +0900 (JST) FUJITA Tomonori <[email protected]> wrote:
> On Wed, 06 Feb 2013 12:33:48 +0900 > HIYAMA Manabu <[email protected]> wrote: > > > > > On Wed, 06 Feb 2013 12:01:54 +0900 (JST) > > FUJITA Tomonori <[email protected]> wrote: > > > >> On Wed, 6 Feb 2013 11:17:30 +0900 > >> HIYAMA Manabu <[email protected]> wrote: > >> > >> > ERROR: Failure: AttributeError ('module' object has no attribute > >> > 'IPPROTO_ICMP6') > >> > ---------------------------------------------------------------------- > >> > Traceback (most recent call last): > >> > (...) > >> > File "/home/openflow/git/osrg/ryu/ryu/lib/packet/ipv6.py", line 68, in > >> > <module> > >> > ipv6.register_packet_type(icmp6.icmp6, inet.IPPROTO_ICMP6) > >> > AttributeError: 'module' object has no attribute 'IPPROTO_ICMP6' > >> > > >> > Signed-off-by: HIYAMA Manabu <[email protected]> > >> > --- > >> > ryu/lib/packet/ipv6.py | 2 +- > >> > 1 files changed, 1 insertions(+), 1 deletions(-) > >> > > >> > diff --git a/ryu/lib/packet/ipv6.py b/ryu/lib/packet/ipv6.py > >> > index 4f1325e..6d55e27 100644 > >> > --- a/ryu/lib/packet/ipv6.py > >> > +++ b/ryu/lib/packet/ipv6.py > >> > @@ -65,5 +65,5 @@ class ipv6(packet_base.PacketBase): > >> > self.src, self.dst) > >> > return hdr > >> > > >> > -ipv6.register_packet_type(icmp6.icmp6, inet.IPPROTO_ICMP6) > >> > +ipv6.register_packet_type(icmp6.icmp6, inet.IPPROTO_ICMPV6) > >> > ipv6.register_packet_type(tcp.tcp, inet.IPPROTO_TCP) > >> > >> Oops, thanks. Applied. Better to rename icmp6 to icmpv6? > > > > It is not needed immediately. But I think it is better to rename the name > > of variable to consistent with other codes (such as"ICMPV4/ICMPV6 in > > parser). > > Seems that google says icpmv6 is commonly used so let's rename it. Can > you send such patch? > > Thanks, OK. I will send a patch. Please wait a little. ------------------------------------------------------------------------------ Free Next-Gen Firewall Hardware Offer Buy your Sophos next-gen firewall before the end March 2013 and get the hardware for free! Learn more. http://p.sf.net/sfu/sophos-d2d-feb _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
