hi,

> On Wed, 13 Feb 2013 16:10:17 +0900
> YAMAMOTO Takashi <[email protected]> wrote:
> 
>> cbench results before the change:
>> cbench
>> RESULT: 16 switches 15 tests min/max/avg/stdev = 
>> 8257.99/8485.97/8348.71/70.46 responses/s
>> cbench -t
>> RESULT: 16 switches 15 tests min/max/avg/stdev = 
>> 8050.82/20660.79/14935.69/3820.58 responses/s
>> 
>> after:
>> cbench
>> RESULT: 16 switches 15 tests min/max/avg/stdev = 
>> 8667.97/8952.98/8784.83/100.40 responses/s
>> cbench -t
>> RESULT: 16 switches 15 tests min/max/avg/stdev = 
>> 7519.74/26297.58/16418.37/7023.93 responses/s
>> 
>> Signed-off-by: YAMAMOTO Takashi <[email protected]>
>> ---
>>  ryu/controller/controller.py | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/ryu/controller/controller.py b/ryu/controller/controller.py
>> index 9dc745a..1e029e9 100644
>> --- a/ryu/controller/controller.py
>> +++ b/ryu/controller/controller.py
>> @@ -155,7 +155,7 @@ class Datapath(object):
>>  
>>          count = 0
>>          while self.is_active:
>> -            ret = self.socket.recv(required_len)
>> +            ret = self.socket.recv(4096)
>>              if len(ret) == 0:
>>                  self.is_active = False
>>                  break
> 
> Long time ago, we tried to read more here and it hurts the
> performance. Please take a look at: commit
> f6741e9c9345ae282679b40fc11da5188c028eee. I'm not sure that we can

i wasn't aware of the commit, thanks.
do you have numbers?

> find the best value that works well in every systems. It depends on
> workload, hardware, etc.

sure, it depends.
but OFP_HEADER_SIZE looks too small to me.
it should be large enough to receive common size messages.

YAMAMOTO Takashi

> 
> ------------------------------------------------------------------------------
> Free Next-Gen Firewall Hardware Offer
> Buy your Sophos next-gen firewall before the end March 2013 
> and get the hardware for free! Learn more.
> http://p.sf.net/sfu/sophos-d2d-feb
> _______________________________________________
> Ryu-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/ryu-devel

------------------------------------------------------------------------------
Free Next-Gen Firewall Hardware Offer
Buy your Sophos next-gen firewall before the end March 2013 
and get the hardware for free! Learn more.
http://p.sf.net/sfu/sophos-d2d-feb
_______________________________________________
Ryu-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ryu-devel

Reply via email to