Hi. On Tue, Feb 19, 2013 at 03:07:02PM +0100, Piotr Niedzwiedz wrote: > There are several modules where this kind of mapping is required: > > - /app/simple_isolation.py > - /app/gre_tunnel.py > - /app/simple_switch.py > - /tests/mininet/l2/vlan/test_vlan.py > - /tests/mininet/l2/mpls/test_mpls.py > - /tests/mininet/l3/ip_ttl/test_ip_ttl.py > - /tests/mininet/l3/icmp/test_icmp.py > > but only in /app/simple_isolation.py module mac_to_port.MacToPortTable is > used. > > To make it more consistent I suggest two options: > a) improve a little bit /controller/mac_to_port module and then apply it in > all listed modules > b) remove /controller/mac_to_port.py file and remove it from > /app/simple_isolation.py > > What do you recommend?
- test_xxx.py: self.mac_to_port isn't used. They should be eliminated? I did only quick grep. So I can be wrong. - simple_switch.py: It is the first simple sample. So just keep it simple. - gre_tunnel.py: The variable is used for different purpose. It maps mac address to tunnel port. So it's no applicable to code consolidation. - simple_isolation.py Hmm this is the only user of mac_to_port (and mac_to_network). Probably it would be to put those file under a dedicated directory. (with adjusting import path) thanks, > > Thanks, > Piotr Niedzwiedz > > > > ------------------------------------------------------------------------------ > Everyone hates slow websites. So do we. > Make your web apps faster with AppDynamics > Download AppDynamics Lite for free today: > http://p.sf.net/sfu/appdyn_d2d_feb > _______________________________________________ > Ryu-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/ryu-devel > -- yamahata ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
