Hi Hiyama,

        I will change my OVS version, but right now want to stay with OF1.0 to 
be able
to fix this issue.

I started adding support of OF1.0 into tests cases, but I noticed, that 
ofproto_v1_0_parser.OFPMatch and ofproto_v1_2_parser.OFPMatch don't have the 
same interface,
moreover theirs constructors are different too :(

It is not nice feature, because in most RYU applications which I've seen people 
just
don't care about it, and just use ofproto_parser from datapath object.

I propose to fix those tests in one of following ways:
a) change test_*.py files to be more OFversion aware (some if statements…).
b) change ofproto_v1_0_parser.OFPMatch to have similar constructor to its 
equivalent from ofproto_v1_2
c) change mininet tests  that they classify mismatch in OF version as skipped 
tests instead NG

I don't know how important is OpenFlow 1.0 for us. If it is, I suggest to 
consider and discuss option b) in separate thread,
if no I suggest option c).

Please advice, thanks,
Piotr Niedzwiedz


        
On Feb 26, 2013, at 3:30 AM, HIYAMA Manabu <[email protected]> wrote:

> Hi Piotr,
> 
> I understand your environment.
> As you say, OVS that version does not support OF1.2.
> If possible, please download the latest version from here:
> 
> git://openvswitch.org/openvswitch
> 
> I recommend you uninstall the current OVS before installing this.
> The install procedure is as follows. For more information please see 
> "openvswitch/INSTALL".
> 
> $ git clone git://openvswitch.org/openvswitch
> $ cd openvswitch
> $ ./boot.sh
> $ ./configure --with-linux=/lib/modules/`uname -r`/build
> $ make
> $ sudo make install
> $ sudo make modules_install
> $ sudo depmod -a
> $ sudo /usr/local/share/openvswitch/scripts/ovs-ctl start
> * Starting ovsdb-server
> * system ID not configured, please use --system-id
> * Configuring Open vSwitch system IDs
> * Starting ovs-vswitchd
> $ sudo ovs-vsctl --version
> ovs-vsctl (Open vSwitch) 1.10.90
> Compiled Feb 25 2013 14:33:12
> 
> Also, you can read the FAQ about OF1.2 support. In the following part:
> "Q: What versions of OpenFlow does Open vSwitch support?"
> 
>> Moreover, there is still problem with NXST_FLOW reply (xid=0x4). What do you 
>> mean in:
> After this message, the list of flow should be output.
> I thought cause the test to fail is that the flow has not been set.
> 
> In addition, I want to improve that the test does not work with OF1.0.
> 
> Thanks,
> 
>> Hi Hiyama,
>> 
>>      I've upgraded my Ubuntu to 12.10 and have installed the latest version 
>> of MiniNet and Openvswitch from
>> Ubuntu repositories.
>> 
>> # mn --version
>> 2.0.0
>> 
>> # ovs-vswitchd --version
>> ovs-vswitchd (Open vSwitch) 1.4.3
>> Compiled Feb 18 2013 12:58:36
>> OpenFlow versions 0x1:0x1
>> 
>> Right now mininet tests still don't work. Logs summary:
>> 
>> ---------- test results ----------
>> ./packet_lib/arp/ARP_request.mn : NG (unmatched packet. please check 
>> /tmp/test-mn/dump/ARP_request.dump)
>> ./packet_lib/arp/ARP_gratuitous.mn : NG (unmatched packet. please check 
>> /tmp/test-mn/dump/ARP_gratuitous.dump)
>> ./packet_lib/arp/ARP_reply.mn : NG (unmatched packet. please check 
>> /tmp/test-mn/dump/ARP_reply.dump)
>> ./l2/vlan/PopVLAN_vlanvlan.mn : NG (unmatched packet. please check 
>> /tmp/test-mn/dump/PopVLAN_vlanvlan.dump)
>> ./l2/vlan/PushVLAN_icmp.mn : NG (unmatched packet. please check 
>> /tmp/test-mn/dump/PushVLAN_icmp.dump)
>> ./l2/vlan/PopVLAN_vlan.mn : NG (unmatched packet. please check 
>> /tmp/test-mn/dump/PopVLAN_vlan.dump)
>> ./l2/mpls/PushMPLS_mpls.mn : NG (unmatched packet. please check 
>> /tmp/test-mn/dump/PushMPLS_mpls.dump)
>> ./l2/mpls/PushMPLS_ip.mn : NG (unmatched packet. please check 
>> /tmp/test-mn/dump/PushMPLS_ip.dump)
>> ./l2/mpls/PopMPLS_mpls.mn : NG (unmatched packet. please check 
>> /tmp/test-mn/dump/PopMPLS_mpls.dump)
>> ./l3/icmp/ICMP_reply.mn : NG (unmatched packet. please check 
>> /tmp/test-mn/dump/ICMP_reply.dump)
>> ./l3/icmp/ICMP_ping.mn : NG (unmatched packet. please check 
>> /tmp/test-mn/dump/ICMP_ping.dump)
>> ./l3/ip_ttl/DecNwTtl.mn : NG (unmatched packet. please check 
>> /tmp/test-mn/dump/DecNwTtl.dump)
>> ----------------------------------
>>      
>> Here are my latest logs from running mininet tests:
>>      http://pastebin.com/EyWP34r3
>> 
>> 
>> I take a look at the file  /tmp/test-mn/dump/ryu-manager.ARP_request.log  
>> (you can find it here http://pastebin.com/z2UshVBv). 
>> 
>> I looks like my switch which is used for testing doesn't support OpenFlow 
>> 1.2 (ovs-vswitchd --versions confirms it):
>> 
>> Part of ryu-manager.ARP_request.log:
>> 
>> EVENT ofp_event->dpset EventOFPStateChange
>> hello ev <ryu.controller.ofp_event.EventOFPHello object at 0x2c44350>
>> unsupported version 0x1. If possible, set the switch to use one of the 
>> versions [3]
>> 
>> 
>> Moreover, there is still problem with NXST_FLOW reply (xid=0x4). What do you 
>> mean in:
>>> In addition, I found the place to be worried about.
>>> It is that the flow is not set to ovs.
>> 
>> 
>> Is there any way to add OF1.2/1.3 support to my OpenvSwitch from Ubuntu12.10 
>> repository ?
>> It is my beginnings with OVS, so I'm sorry when I am asking you about 
>> trivial things.
>> 
>> Thanks,
>> Piotr Niedzwiedz
>> 
>>      
>> On Feb 25, 2013, at 8:02 AM, HIYAMA Manabu <[email protected]> 
>> wrote:
>> 
>>> Hi Piotr,
>>> 
>>> Thank you. I found the following error message in the log.
>>>> Error: run_ryu() : failed to start ryu-manager.
>>> Please check the ryu-manager logs: /tmp/test-mn/dump/ryu-manager.*.log
>>> 
>>> In addition, I found the place to be worried about.
>>> It is that the flow is not set to ovs.
>>>> NXST_FLOW reply (xid=0x4):
>>> Similarly, please check the ryu-manager logs too.
>>> 
>>>> Can you share with me what environment you have?
>>>>    - operation system
>>>>    - mininet version
>>> 
>>> Yes, my environment is as follows:
>>> - OS: ubuntu 12.04
>>> - mininet: 2.0.0, git://github.com/mininet/mininet
>>> - ovs: git://github.com/osrg/openvswitch.git -b of12 (supported MPLS)
>>> 
>>> Now, I've run in openvswitch of upstream.
>>> (version:1.10.90, git://openvswitch.org/openvswitch)
>>> Except the MPLS unsupported, it all worked.
>>> 
>>> ---------- test results ----------
>>> ./ryu/tests/mininet/l2/vlan/PushVLAN_icmp.mn : OK
>>> ./ryu/tests/mininet/l2/vlan/PopVLAN_vlan.mn : OK
>>> ./ryu/tests/mininet/l2/vlan/PopVLAN_vlanvlan.mn : OK
>>> ./ryu/tests/mininet/l2/mpls/PushMPLS_ip.mn : NG (unmatched packet. please 
>>> check /tmp/test-mn/dump/PushMPLS_ip.dump)
>>> ./ryu/tests/mininet/l2/mpls/PushMPLS_mpls.mn : NG (unmatched packet. please 
>>> check /tmp/test-mn/dump/PushMPLS_mpls.dump)
>>> ./ryu/tests/mininet/l2/mpls/PopMPLS_mpls.mn : NG (unmatched packet. please 
>>> check /tmp/test-mn/dump/PopMPLS_mpls.dump)
>>> ./ryu/tests/mininet/packet_lib/arp/ARP_request.mn : OK
>>> ./ryu/tests/mininet/packet_lib/arp/ARP_gratuitous.mn : OK
>>> ./ryu/tests/mininet/packet_lib/arp/ARP_reply.mn : OK
>>> ./ryu/tests/mininet/l3/icmp/ICMP_ping.mn : OK
>>> ./ryu/tests/mininet/l3/icmp/ICMP_reply.mn : OK
>>> ./ryu/tests/mininet/l3/ip_ttl/DecNwTtl.mn : OK
>>> ----------------------------------
>>> Ran 12 tests. Result: OK=9 NG=3
>>> 
>>> 
>>> Thanks,
>>> 
>>> On Fri, 22 Feb 2013 15:24:25 +0100
>>> Piotr Niedzwiedz <[email protected]> wrote:
>>> 
>>>> Hi Hiyama,
>>>> 
>>>>    Full running logs are here: http://pastebin.com/mzuBDW5A
>>>> 
>>>> Can you share with me what environment you have?
>>>>    - operation system
>>>>    - mininet version
>>>> 
>>>> Thanks,
>>>> Piotr
>>>> 
>>>> On Feb 22, 2013, at 3:36 AM, HIYAMA Manabu <[email protected]> 
>>>> wrote:
>>>> 
>>>>> Hi,
>>>>> 
>>>>> It works in my environment. As the following:
>>>>> Some error message was being displayed?
>>>>> Please send a run-time logs. I'll look into it.
>>>>> 
>>>>> thanks,
>>>>> 
>>>>> $ sudo /usr/local/share/openvswitch/scripts/ovs-ctl start
>>>>> * Starting ovsdb-server
>>>>> * system ID not configured, please use --system-id
>>>>> * Configuring Open vSwitch system IDs
>>>>> * Starting ovs-vswitchd
>>>>> $ ryu/tests/mininet/run_mnet-test.sh
>>>>> 
>>>>> ---------- test target ----------
>>>>> ./ryu/tests/mininet/packet_lib/arp/ARP_request.mn
>>>>> ./ryu/tests/mininet/packet_lib/arp/ARP_gratuitous.mn
>>>>> ./ryu/tests/mininet/packet_lib/arp/ARP_reply.mn
>>>>> ./ryu/tests/mininet/l2/vlan/PopVLAN_vlan.mn
>>>>> ./ryu/tests/mininet/l2/vlan/PopVLAN_vlanvlan.mn
>>>>> ./ryu/tests/mininet/l2/vlan/PushVLAN_icmp.mn
>>>>> ./ryu/tests/mininet/l2/mpls/PushMPLS_mpls.mn
>>>>> ./ryu/tests/mininet/l2/mpls/PopMPLS_mpls.mn
>>>>> ./ryu/tests/mininet/l2/mpls/PushMPLS_ip.mn
>>>>> ./ryu/tests/mininet/l3/ip_ttl/DecNwTtl.mn
>>>>> ./ryu/tests/mininet/l3/icmp/ICMP_reply.mn
>>>>> ./ryu/tests/mininet/l3/icmp/ICMP_ping.mn
>>>>> 
>>>>> ---------- test [./ryu/tests/mininet/packet_lib/arp/ARP_request.mn] start 
>>>>> ----------
>>>>> Inf: RYU_APP=/home/openflow/ryu/ryu/tests/mininet/packet_lib/arp/test_arp
>>>>> Inf: ryu-manager starting...
>>>>> Info: mininet starting...
>>>>> *** Creating network
>>>>> *** Adding controller
>>>>> *** Adding hosts:
>>>>> h1 h2
>>>>> *** Adding switches:
>>>>> s1
>>>>> *** Adding links:
>>>>> (h1, s1) (h2, s1)
>>>>> *** Configuring hosts
>>>>> h1 h2
>>>>> *** Starting CLI:
>>>>> ----------------------------------
>>>>> (pre) mininet topology dump.
>>>>> ----------------------------------
>>>>> <RemoteController c0: 127.0.0.1:6633 pid=27640>
>>>>> <OVSSwitch s1: lo:127.0.0.1,s1-eth1:None,s1-eth2:None pid=27651>
>>>>> <Host h1: h1-eth0:10.0.0.1 pid=27647>
>>>>> <Host h2: h2-eth0:10.0.0.2 pid=27648>
>>>>> c0
>>>>> s1 lo:  s1-eth1:h1-eth0 s1-eth2:h2-eth0
>>>>> h1 h1-eth0:s1-eth1
>>>>> h2 h2-eth0:s1-eth2
>>>>> ----------------------------------
>>>>> (pre) tshark start.
>>>>> ----------------------------------
>>>>> ----------------------------------
>>>>> *** Starting controller
>>>>> *** Starting 1 switches
>>>>> s1
>>>>> *** Starting CLI:
>>>>> ----------------------------------
>>>>> (post) packet sending...
>>>>> ----------------------------------
>>>>> tshark: Lua: Error during loading:
>>>>> [string "/usr/share/wireshark/init.lua"]:45: dofile has been disabled
>>>>> Running as user "root" and group "root". This could be dangerous.
>>>>> Capturing on h1-eth0
>>>>> 2
>>>>> ----------------------------------
>>>>> (post) dump flows.
>>>>> ----------------------------------
>>>>> NXST_FLOW reply (xid=0x4):
>>>>> ----------------------------------
>>>>> *** Stopping 2 hosts
>>>>> h1 h2
>>>>> *** Stopping 1 switches
>>>>> s1 ...
>>>>> *** Stopping 1 controllers
>>>>> c0
>>>>> *** Done
>>>>> completed in 4.307 seconds
>>>>> 
>>>>> TEST ARP-Request : OK
>>>>> 
>>>>> ---------- test [./ryu/tests/mininet/packet_lib/arp/ARP_request.mn] 
>>>>> finished : OK ----------
>>>>> 
>>>>> (...)
>>>>> 
>>>>> ---------- test results ----------
>>>>> ./ryu/tests/mininet/packet_lib/arp/ARP_request.mn : OK
>>>>> ./ryu/tests/mininet/packet_lib/arp/ARP_gratuitous.mn : OK
>>>>> ./ryu/tests/mininet/packet_lib/arp/ARP_reply.mn : OK
>>>>> ./ryu/tests/mininet/l2/vlan/PopVLAN_vlan.mn : OK
>>>>> ./ryu/tests/mininet/l2/vlan/PopVLAN_vlanvlan.mn : OK
>>>>> ./ryu/tests/mininet/l2/vlan/PushVLAN_icmp.mn : OK
>>>>> ./ryu/tests/mininet/l2/mpls/PushMPLS_mpls.mn : OK
>>>>> ./ryu/tests/mininet/l2/mpls/PopMPLS_mpls.mn : OK
>>>>> ./ryu/tests/mininet/l2/mpls/PushMPLS_ip.mn : OK
>>>>> ./ryu/tests/mininet/l3/ip_ttl/DecNwTtl.mn : OK
>>>>> ./ryu/tests/mininet/l3/icmp/ICMP_reply.mn : OK
>>>>> ./ryu/tests/mininet/l3/icmp/ICMP_ping.mn : OK
>>>>> ----------------------------------
>>>>> Ran 12 tests. Result: OK=12
>>>>> 
>>>>> 
>>>>> On Thu, 21 Feb 2013 11:27:14 +0100
>>>>> Piotr Niedzwiedz <[email protected]> wrote:
>>>>> 
>>>>>> Hi,
>>>>>>  
>>>>>>  I launched them but most of them failed, part of them were skipped.
>>>>>> 
>>>>>> Do they work correctly on yours machines?
>>>>>> 
>>>>>> If they are valuable, I can explore what is wrong and try fix it. Please 
>>>>>> let me know.
>>>>>> 
>>>>>> Thanks,
>>>>>> Piotr Niedzwiedz
>>>>>> 
>>>>>> 
>>>>>> Summary of tests:
>>>>>> ./l2/vlan/PushVLAN_icmp.mn : NG (unmatched packet. please check 
>>>>>> /tmp/test-mn/dump/PushVLAN_icmp.dump)
>>>>>> ./l2/vlan/PopVLAN_vlan.mn : NG (unmatched packet. please check 
>>>>>> /tmp/test-mn/dump/PopVLAN_vlan.dump)
>>>>>> ./l2/vlan/PopVLAN_vlanvlan.mn : NG (unmatched packet. please check 
>>>>>> /tmp/test-mn/dump/PopVLAN_vlanvlan.dump)
>>>>>> ./l2/mpls/PushMPLS_mpls.mn : NG (unmatched packet. please check 
>>>>>> /tmp/test-mn/dump/PushMPLS_mpls.dump)
>>>>>> ./l2/mpls/PopMPLS_mpls.mn : NG (unmatched packet. please check 
>>>>>> /tmp/test-mn/dump/PopMPLS_mpls.dump)
>>>>>> ./l2/mpls/PushMPLS_ip.mn : NG (unmatched packet. please check 
>>>>>> /tmp/test-mn/dump/PushMPLS_ip.dump)
>>>>>> ./l3/ip_ttl/DecNwTtl.mn : NG (unmatched packet. please check 
>>>>>> /tmp/test-mn/dump/DecNwTtl.dump)
>>>>>> ./l3/icmp/ICMP_ping.mn : NG (unmatched packet. please check 
>>>>>> /tmp/test-mn/dump/ICMP_ping.dump)
>>>>>> ./l3/icmp/ICMP_reply.mn : NG (unmatched packet. please check 
>>>>>> /tmp/test-mn/dump/ICMP_reply.dump)
>>>>>> ./packet_lib/arp/ARP_request.mn : skip (unmatched packet. please check 
>>>>>> /tmp/test-mn/dump/ICMP_reply.dump)
>>>>>> ./packet_lib/arp/ARP_reply.mn : skip (unmatched packet. please check 
>>>>>> /tmp/test-mn/dump/ICMP_reply.dump)
>>>>>> ./packet_lib/arp/ARP_gratuitous.mn : skip (unmatched packet. please 
>>>>>> check /tmp/test-mn/dump/ICMP_reply.dump)
>>>>>> 
>>>>>> 
>>>>>> Full logs here:
>>>>>> http://pastebin.com/mzuBDW5A
>>>>>> 
>>>>>> 
>>>>>> ------------------------------------------------------------------------------
>>>>>> Everyone hates slow websites. So do we.
>>>>>> Make your web apps faster with AppDynamics
>>>>>> Download AppDynamics Lite for free today:
>>>>>> http://p.sf.net/sfu/appdyn_d2d_feb
>>>>>> _______________________________________________
>>>>>> Ryu-devel mailing list
>>>>>> [email protected]
>>>>>> https://lists.sourceforge.net/lists/listinfo/ryu-devel
>>>>> 
>>>>> 
>>>>> 
>>>>> ------------------------------------------------------------------------------
>>>>> Everyone hates slow websites. So do we.
>>>>> Make your web apps faster with AppDynamics
>>>>> Download AppDynamics Lite for free today:
>>>>> http://p.sf.net/sfu/appdyn_d2d_feb
>>>>> _______________________________________________
>>>>> Ryu-devel mailing list
>>>>> [email protected]
>>>>> https://lists.sourceforge.net/lists/listinfo/ryu-devel
>>>> 
>>>> 
>>>> ------------------------------------------------------------------------------
>>>> Everyone hates slow websites. So do we.
>>>> Make your web apps faster with AppDynamics
>>>> Download AppDynamics Lite for free today:
>>>> http://p.sf.net/sfu/appdyn_d2d_feb
>>>> _______________________________________________
>>>> Ryu-devel mailing list
>>>> [email protected]
>>>> https://lists.sourceforge.net/lists/listinfo/ryu-devel
>>> 
>>> 
>>> 
>> 
>> 
>> ------------------------------------------------------------------------------
>> Everyone hates slow websites. So do we.
>> Make your web apps faster with AppDynamics
>> Download AppDynamics Lite for free today:
>> http://p.sf.net/sfu/appdyn_d2d_feb
>> _______________________________________________
>> Ryu-devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/ryu-devel
> 
> 
> 


------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_feb
_______________________________________________
Ryu-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ryu-devel

Reply via email to