On Wed, 6 Mar 2013 10:42:57 +0900 (JST) [email protected] (YAMAMOTO Takashi) wrote:
>> On Tue, 5 Mar 2013 13:18:02 +0900 >> YAMAMOTO Takashi <[email protected]> wrote: >> >>> because all of its possible users are commented out. >>> >>> Signed-off-by: YAMAMOTO Takashi <[email protected]> >>> --- >>> ryu/app/wsgi.py | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/ryu/app/wsgi.py b/ryu/app/wsgi.py >>> index 3779b08..68a7b28 100644 >>> --- a/ryu/app/wsgi.py >>> +++ b/ryu/app/wsgi.py >>> @@ -22,7 +22,7 @@ from gevent import pywsgi >>> from routes import Mapper >>> from routes.util import URLGenerator >>> >>> -LOG = logging.getLogger('ryu.app.wsgi') >>> +# LOG = logging.getLogger('ryu.app.wsgi') >> >> How about removing it? > > i have no opinion. > > the code in question was added by commit 32cb6a21 (you) and > the commit log says nothing about it. > i guess it's ok to remove it. ok, then remove all the unused logging code. diff --git a/ryu/app/wsgi.py b/ryu/app/wsgi.py index 3779b08..f879b90 100644 --- a/ryu/app/wsgi.py +++ b/ryu/app/wsgi.py @@ -15,14 +15,12 @@ # limitations under the License. from oslo.config import cfg -import logging import webob.dec from gevent import pywsgi from routes import Mapper from routes.util import URLGenerator -LOG = logging.getLogger('ryu.app.wsgi') CONF = cfg.CONF CONF.register_cli_opts([ @@ -53,7 +51,6 @@ class ControllerBase(object): if attr in kwargs: del kwargs[attr] - # LOG.debug('kwargs %s', kwargs) return getattr(self, action)(req, **kwargs) @@ -66,9 +63,6 @@ class WSGIApplication(object): @webob.dec.wsgify def __call__(self, req): - # LOG.debug('mapper %s', self.mapper) - # LOG.debug('req: %s\n', req) - # LOG.debug('\nreq.environ: %s', req.environ) match = self.mapper.match(environ=req.environ) if not match: ------------------------------------------------------------------------------ Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the endpoint security space. For insight on selecting the right partner to tackle endpoint security challenges, access the full report. http://p.sf.net/sfu/symantec-dev2dev _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
