I haven't looked details yet, but some general comment. - pep8 please Or you seem to use old version of pep8 shipped by distro. Please use latest pep8 - Please consistent indentation Maybe it's a matter of taste, but please be consistent in at least single file.
thanks On Fri, Mar 15, 2013 at 11:02:53AM +0900, watanabe.fumitaka wrote: > This patch implements a Firewall Ryu application. > > It can control the packets(ALLOW or DENY) > by the ACL rules(Access Control List) on OpenFlow. > The ACL rules is operated by the REST messages. > > ryu/app: add firewall Ryu apllication > ryu/lib: update openflow v1.0 control library > and add openflow v1.2 control library > > --- > ryu/app/rest_firewall.py | 648 > ++++++++++++++++++++++++++++++++++++++++++++++ > ryu/lib/ofctl_v1_0.py | 28 +- > ryu/lib/ofctl_v1_2.py | 255 ++++++++++++++++++ > 3 files changed, 928 insertions(+), 3 deletions(-) > create mode 100644 ryu/app/rest_firewall.py > create mode 100755 ryu/lib/ofctl_v1_2.py > > ------------------------------------------------------------------------------ > Everyone hates slow websites. So do we. > Make your web apps faster with AppDynamics > Download AppDynamics Lite for free today: > http://p.sf.net/sfu/appdyn_d2d_mar > _______________________________________________ > Ryu-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/ryu-devel > -- yamahata ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_mar _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
