> On Tue, 12 Mar 2013 14:20:41 +0900 > YAMAMOTO Takashi <[email protected]> wrote: > >> according to FUJITA Tomonori, these are internal methods. >> prefix them with '_' to make it clear and avoid further abuses. >> >> Signed-off-by: YAMAMOTO Takashi <[email protected]> >> --- >> ryu/app/gre_tunnel.py | 4 +++- >> ryu/base/app_manager.py | 16 ++++++++-------- >> ryu/controller/controller.py | 2 +- >> 3 files changed, 12 insertions(+), 10 deletions(-) >> >> diff --git a/ryu/app/gre_tunnel.py b/ryu/app/gre_tunnel.py >> index 29e8cab..01f9cd7 100644 >> --- a/ryu/app/gre_tunnel.py >> +++ b/ryu/app/gre_tunnel.py >> @@ -394,7 +394,9 @@ class GRETunnel(app_manager.RyuApp): >> self.tunnels = kwargs['tunnels'] >> >> self.port_set = PortSet(**kwargs) >> - map(lambda ev_cls: self.port_set.register_observer(ev_cls, >> self.name), >> + >> + # XXX should not call _register_observer directly >> + map(lambda ev_cls: self.port_set._register_observer(ev_cls, >> self.name), >> [dpset.EventDP, PortSet.EventTunnelKeyDel, PortSet.EventVMPort, >> PortSet.EventTunnelPort, ofp_event.EventOFPPacketIn]) > > I prefer to _fix_ gre_tunnel.py first with the planned Quantum code > cleanups.
i can keep this in my local tree until that if you prefer. IMO there's no point to "fix" apps without changing these methods internal, though. YAMAMOTO Takashi > > ------------------------------------------------------------------------------ > Everyone hates slow websites. So do we. > Make your web apps faster with AppDynamics > Download AppDynamics Lite for free today: > http://p.sf.net/sfu/appdyn_d2d_mar > _______________________________________________ > Ryu-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/ryu-devel ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_mar _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
