Now the LLDP packets are printed as:
<ryu.lib.packet.lldp.lldp object at 0x10dc44050>
and formerly the packets are shown as:
<ryu.lib.packet.lldp.ChassisID object at
0x1055edfd0><ryu.lib.packet.lldp.PortID object at
0x1055f3350><ryu.lib.packet.lldp.TTL object at
0x1055f3050><ryu.lib.packet.lldp.End object at 0x1055f3210>
I think the patch is OK to me.
2013/4/9 Isaku Yamahata <[email protected]>
> Those methods are legacy when lldp.py was written for dpkt.
> They don't make sense. remove them.
>
> Cc: "can." <[email protected]>
> Signed-off-by: Isaku Yamahata <[email protected]>
> ---
> ryu/lib/packet/lldp.py | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/ryu/lib/packet/lldp.py b/ryu/lib/packet/lldp.py
> index f82e00a..d913c30 100644
> --- a/ryu/lib/packet/lldp.py
> +++ b/ryu/lib/packet/lldp.py
> @@ -102,10 +102,6 @@ class LLDPBasicTLV(object):
> def _len_valid(self):
> return self._LEN_MIN <= self.len and self.len <= self._LEN_MAX
>
> - def __str__(self):
> - self._typelen()
> - return super(LLDPBasicTLV, self).__str__()
> -
>
> class lldp(packet_base.PacketBase):
> _tlv_parsers = {}
> @@ -130,11 +126,6 @@ class lldp(packet_base.PacketBase):
> self.tlvs[2].tlv_type == LLDP_TLV_TTL and
> self.tlvs[-1].tlv_type == LLDP_TLV_END)
>
> - def __str__(self):
> - assert self._tlvs_len_valid()
> - assert self._tlvs_valid()
> - return ''.join(str(tlv) for tlv in self.tlvs)
> -
> @classmethod
> def parser(cls, buf):
> tlvs = []
> --
> 1.7.10.4
>
>
--
Best regards,
Can Zhang
------------------------------------------------------------------------------
Precog is a next-generation analytics platform capable of advanced
analytics on semi-structured data. The platform includes APIs for building
apps and a phenomenal toolset for data science. Developers can use
our toolset for easy data analysis & visualization. Get a free account!
http://www2.precog.com/precogplatform/slashdotnewsletter
_______________________________________________
Ryu-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ryu-devel
