On Fri, 12 Apr 2013 09:45:05 -0300
Eder Le$(D+*(Bo Fernandes <[email protected]> wrote:
> This patch add missing group special values of OpenFlow 1.3, added to
> the 1.3.1 version.
>
> It is useful to create a flow_mod message with an out_group with no
> group restrictions and for flow_stats messages.
>
>
>
> diff --git a/ryu/ofproto/ofproto_v1_3.py b/ryu/ofproto/ofproto_v1_3.py
> index 4699aef..307e069 100644
> --- a/ryu/ofproto/ofproto_v1_3.py
> +++ b/ryu/ofproto/ofproto_v1_3.py
> @@ -416,6 +416,14 @@ OFPGC_ADD = 0 # New group.
> OFPGC_MODIFY = 1 # Modify all matching groups.
> OFPGC_DELETE = 2 # Delete all matching groups.
>
> +# enum ofp_group
> +OFPG_MAX = 0xffffff00 # Last usable group number.
> +#Fake groups
> +OFPG_ALL = 0xfffffffc # Represents all groups for group delete commands.
> +OFPG_ANY = 0xffffffff #Wildcard group used only for flow stats requests.
> + #Selects all flows regardless of group
> + #(including flows with no group).
> +
> # enum ofp_group_type
> OFPGT_ALL = 0 # All (multicast/broadcast) group.
> OFPGT_SELECT = 1 # Select group.
Thanks, looks good, however I got pep8 errors with this patch:
fujita@rouen:~/git/ryu$ ./run_tests.sh -p
Running pep8 ...
ryu/ofproto/ofproto_v1_3.py:420:22: E261 at least two spaces before inline
comment
OFPG_MAX = 0xffffff00 # Last usable group number.
^
ryu/ofproto/ofproto_v1_3.py:422:22: E261 at least two spaces before inline
comment
OFPG_ALL = 0xfffffffc # Represents all groups for group delete commands.
^
ryu/ofproto/ofproto_v1_3.py:423:22: E261 at least two spaces before inline
comment
OFPG_ANY = 0xffffffff #Wildcard group used only for flow stats requests.
^
I fixed them and merged this. Next time please do pep8 checking before
sending a patch. Also please send a patch with your signed-off-by.
Thanks!
------------------------------------------------------------------------------
Precog is a next-generation analytics platform capable of advanced
analytics on semi-structured data. The platform includes APIs for building
apps and a phenomenal toolset for data science. Developers can use
our toolset for easy data analysis & visualization. Get a free account!
http://www2.precog.com/precogplatform/slashdotnewsletter
_______________________________________________
Ryu-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ryu-devel
