On Sun, 28 Apr 2013 15:09:00 +0800
Can Zhang <[email protected]> wrote:

> > +        if in_port is None:
> > +            self.in_port = 0
> 
> I think None should be OFPP_NONE here, not zero
> Other parts look fine, please update the repo.

Hmm, I'm not sure. if in_port is None, we don't clear OFPFW_IN_PORT
bit. So as long as a value makes its serialize() happy, it doesn't
matter. The spec says that in_port in OFPMatch should be OFPP_NONE
when OFPFW_IN_PORT bit is not cleared?

------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
_______________________________________________
Ryu-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ryu-devel

Reply via email to