Oops. The both patches looks good. On Tue, May 21, 2013 at 01:44:09PM +0900, YAMADA Hideki wrote: > > Signed-off-by: YAMADA Hideki <[email protected]> > --- > ryu/lib/packet/vrrp.py | 10 +++++----- > 1 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/ryu/lib/packet/vrrp.py b/ryu/lib/packet/vrrp.py > index 7c50fed..8b6140a 100644 > --- a/ryu/lib/packet/vrrp.py > +++ b/ryu/lib/packet/vrrp.py > @@ -395,7 +395,7 @@ class vrrp(packet_base.PacketBase): > > def is_valid(self): > cls = self._VRRP_VERSIONS.get(self.version, None) > - if None: > + if cls is None: > return False > return cls.is_valid(self) > > @@ -499,8 +499,8 @@ class vrrpv2(vrrp): > return (self.version == VRRP_VERSION_V2 and > self.type == VRRP_TYPE_ADVERTISEMENT and > VRRP_VRID_MIN <= self.vrid and self.vrid <= VRRP_VRID_MAX and > - VRRP_PRIORITY_MIN <= self.vrid and > - self.vrid <= VRRP_PRIORITY_MAX and > + VRRP_PRIORITY_MIN <= self.priority and > + self.priority <= VRRP_PRIORITY_MAX and > self.auth_type == VRRP_AUTH_NO_AUTH and > VRRP_V2_MAX_ADVER_INT_MIN <= self.max_adver_int and > self.max_adver_int <= VRRP_V2_MAX_ADVER_INT_MAX and > @@ -616,8 +616,8 @@ class vrrpv3(vrrp): > return (self.version == VRRP_VERSION_V3 and > self.type == VRRP_TYPE_ADVERTISEMENT and > VRRP_VRID_MIN <= self.vrid and self.vrid <= VRRP_VRID_MAX and > - VRRP_PRIORITY_MIN <= self.vrid and > - self.vrid <= VRRP_PRIORITY_MAX and > + VRRP_PRIORITY_MIN <= self.priority and > + self.priority <= VRRP_PRIORITY_MAX and > VRRP_V3_MAX_ADVER_INT_MIN <= self.max_adver_int and > self.max_adver_int <= VRRP_V3_MAX_ADVER_INT_MAX and > self.count_ip == len(self.ip_addresses)) > -- > 1.7.1 > > > > ------------------------------------------------------------------------------ > Try New Relic Now & We'll Send You this Cool Shirt > New Relic is the only SaaS-based application performance monitoring service > that delivers powerful full stack analytics. Optimize and monitor your > browser, app, & servers with just a few lines of code. Try New Relic > and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may > _______________________________________________ > Ryu-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/ryu-devel >
-- yamahata ------------------------------------------------------------------------------ Try New Relic Now & We'll Send You this Cool Shirt New Relic is the only SaaS-based application performance monitoring service that delivers powerful full stack analytics. Optimize and monitor your browser, app, & servers with just a few lines of code. Try New Relic and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
