Great, thanks, will tweak the code and propose a patch soon. > And OFPMeterBandHader should have serialize method, not parser method.
Yes, I agree. I think the parser method is from OFPMeterConfigStats(object): to parse the response? If yes, both is needed > >> Snippet from ofproto_v1_3_parser.py >> >> class OFPMeterBandDrop(object): >> def __init__(self, type_, len_, rate, burst_size): >> super(OFPMeterBandDrop, self).__init__() >> self.type = type_ >> self.len = len_ >> self.rate = rate >> self.burst_size = burst_size >> >> def serialize(self, buf, offset): >> meter_offset = offset >> self.len = ofproto_v1_3.OFP_METER_BAND_DROP_SIZE >> msg_pack_into(ofproto_v1_3.OFP_METER_BAND_DROP_PACK_STR, buf, >> meter_offset, >> self.type, self.len, self.rate, self.burst_size) > > There is no point to use meter_offset. just use offset. Yes, that's not necessary > > thanks, > > > -- > yamahata Thanks yamahata, g *pae ------------------------------------------------------------------------------ Try New Relic Now & We'll Send You this Cool Shirt New Relic is the only SaaS-based application performance monitoring service that delivers powerful full stack analytics. Optimize and monitor your browser, app, & servers with just a few lines of code. Try New Relic and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
