Personally, I prefer keeping the parsing library back-compatible so that the old controller.py should work with the new ofproto, where possible. As Ryu grows, there'll be more and more scripts relying on Ryu so changing the API will be more and more expensive.
-Shaun On 28/05/2013 23:25, "Isaku Yamahata" <[email protected]> wrote: >On Tue, May 28, 2013 at 05:05:12PM +0000, Shaun Crampton wrote: >> >> diff --git a/ryu/ofproto/ofproto_v1_3.py >>b/ryu/ofproto/ofproto_v1_3.py >> >> index 3a40eef..39d7dff 100644 >> >> --- a/ryu/ofproto/ofproto_v1_3.py >> >> +++ b/ryu/ofproto/ofproto_v1_3.py >> >> @@ -97,7 +97,8 @@ OFPP_FLOOD = 0xfffffffb # All physical >>ports >> >> except input port and >> >> OFPP_ALL = 0xfffffffc # All physical ports except input >>port. >> >> OFPP_CONTROLLER = 0xfffffffd # Send to controller. >> >> OFPP_LOCAL = 0xfffffffe # Local openflow "port". >> >> -OFPP_ANY = 0xffffffff # Not associated with a physical >>port. >> >> +OFPP_ANY = 0xffffffff # Not associated with a physical >>port. >> >> +OFPP_NONE = 0xffffffff # Not associated with a physical >>port. >> > >> >Hi. OF1.1+ doesn't define OFPP_NONE. Only OF1.0 defines OFFP_NONE >> >If you need it for compatibility, OFPP_ANY should be used, I suppose. >> >> There are various uses of ofproto.OFPP_NONE in the Ryu codebase, I >>believe >> removing this constant breaks some code paths. Maybe it should be >> retained for backwards compatibility. > >Now I'm seeing your point. Grep tells me that the issue is in only >controoler.py. Given OFPP_NONE is for v1.0 and OFPP_ANY is for OF1.1+. >How about use OFPP_ANY in controller.py and add OFPP_ANY to >ofproto_v1_0_parser? >-- >yamahata ------------------------------------------------------------------------------ Introducing AppDynamics Lite, a free troubleshooting tool for Java/.NET Get 100% visibility into your production application - at no cost. Code-level diagnostics for performance bottlenecks with <2% overhead Download for free and get started troubleshooting in minutes. http://p.sf.net/sfu/appdyn_d2d_ap1 _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
