> On Mon, 3 Jun 2013 13:58:27 +0900 (JST)
> [email protected] (YAMAMOTO Takashi) wrote:
>
>>> On Mon, 3 Jun 2013 12:53:18 +0900 (JST)
>>> [email protected] (YAMAMOTO Takashi) wrote:
>>>
>>>> hi,
>>>>
>>>>> On Thu, May 23, 2013 at 08:07:48PM +0900, FUJITA Tomonori wrote:
>>>>>> On Thu, 23 May 2013 15:30:39 +0900
>>>>>> Isaku Yamahata <[email protected]> wrote:
>>>>>>
>>>>>> > On Thu, May 23, 2013 at 08:53:09AM +0900, FUJITA Tomonori wrote:
>>>>>> > > On Fri, 17 May 2013 11:52:07 +0900
>>>>>> > > YAMAMOTO Takashi <[email protected]> wrote:
>>>>>> > >
>>>>>> > > > 0.3.0 (commit df6449f17366b9d608895766cc1a151167460ae0)
>>>>>> > > >
>>>>>> > > > only pure python code for now because:
>>>>>> > > > - we don't want to worry about cython setup.py stuff
>>>>>> > > > - cython version has a known bug
>>>>>> > > > cf. https://github.com/msgpack/msgpack-python/pull/64
>>>>>> > >
>>>>>> > > Can you describe why we need this in a commit message? However, a fix
>>>>>> > > for this issue was merged into grizzly/stable and master. If so, if
>>>>>> > > we
>>>>>> > > ignore folsom, we don't need to have this in contrib directory,
>>>>>> > > right?
>>>>>> >
>>>>>> > If the next grizzly/stable is released, no, we don't.
>>>>>> > It's about two weeks.
>>>>>>
>>>>>> Then I'm inclined not to put this into contrib. Objections?
>>>>>
>>>>> No objection from me.
>>>>
>>>> cython code in msgpack-python has the above mentioned bug.
>>>> some of unit tests in this patchset fail due to this.
>>>> although i pushed fixes into the upstream, it would be safer
>>>> for us to have it in contrib for a while.
>>>
>>> The above bug is about a value over LONG_MAX? Then unlikely we would
>>> hit it.
>>
>> no.
>> it's about values which don't fit in msgpack 32-bit integer format
>> but fits in C long.
>
> Can you give examples, we would likely hit such bug?
an example:
>>> V=0x100000000
>>> V2=msgpack.unpackb(msgpack.packb(V))
>>> V2
4294967296L
>>> V==V2
True
>>> type(V)
<type 'int'>
>>> type(V2)
<type 'long'>
>>>
w/o cython, type(V2) will be int as expected.
while it does not seem critical, it can cause subtle bugs.
YAMAMOTO Takashi
>
> ------------------------------------------------------------------------------
> Get 100% visibility into Java/.NET code with AppDynamics Lite
> It's a free troubleshooting tool designed for production
> Get down to code-level detail for bottlenecks, with <2% overhead.
> Download for free and get started troubleshooting in minutes.
> http://p.sf.net/sfu/appdyn_d2d_ap2
> _______________________________________________
> Ryu-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/ryu-devel
------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite
It's a free troubleshooting tool designed for production
Get down to code-level detail for bottlenecks, with <2% overhead.
Download for free and get started troubleshooting in minutes.
http://p.sf.net/sfu/appdyn_d2d_ap2
_______________________________________________
Ryu-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ryu-devel
