> On Tue, Jun 18, 2013 at 04:35:32PM +0900, YAMAMOTO Takashi wrote: >> avoid crashing when the switch happens to have flows with >> non OFPInstructionActions instructions. >> >> Signed-off-by: YAMAMOTO Takashi <[email protected]> >> --- >> ryu/lib/ofctl_v1_2.py | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/ryu/lib/ofctl_v1_2.py b/ryu/lib/ofctl_v1_2.py >> index 0789bf6..d08bb21 100644 >> --- a/ryu/lib/ofctl_v1_2.py >> +++ b/ryu/lib/ofctl_v1_2.py >> @@ -50,6 +50,9 @@ def actions_to_str(instructions): >> actions = [] >> >> for instruction in instructions: >> + if not isinstance(instruction, >> + ofproto_v1_2_parser.OFPInstructionActions): >> + continue > > Log it as unsupported? It would be confusing to ignore silently.
IMO logging individual instructions doesn't make much sense. probably it's better to raise an exception and make higher level code deal with it. can someone familiar with rest_firewall.py take a look? YAMAMOTO Takashi > > thanks, > > >> for a in instruction.actions: >> action_type = a.cls_action_type >> >> -- >> 1.8.1.5 >> >> >> ------------------------------------------------------------------------------ >> This SF.net email is sponsored by Windows: >> >> Build for Windows Store. >> >> http://p.sf.net/sfu/windows-dev2dev >> _______________________________________________ >> Ryu-devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/ryu-devel >> > > -- > yamahata > > ------------------------------------------------------------------------------ > This SF.net email is sponsored by Windows: > > Build for Windows Store. > > http://p.sf.net/sfu/windows-dev2dev > _______________________________________________ > Ryu-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/ryu-devel ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
