On Fri, Jul 12, 2013 at 07:27:37AM +0900, FUJITA Tomonori wrote:
> On Wed, 10 Jul 2013 18:35:02 +0900
> Isaku Yamahata <[email protected]> wrote:
> 
> > This patch addresses race condition with openstack which causes in 
> > exceptions.
> > 
> > Changes v2 -> v3:
> > - clean up of controller.network.py for ordering between event and actual
> >   deletion
> > - various minor fixes
> > 
> > Isaku Yamahata (12):
> >   app/gre_tunnel.py: typo has_network -> has_networks
> >   network.py: sort out order between event and actual deletion of port
> >   network: sort out order between event and actual deletion of network
> >   network.py: exception in Networks.remove_port()
> >   gre_tunnel: exception due to race condition
> >   network: add a helper function to list ports that doesn't raise
> >   gre_tunnel.py: race condition
> >   simple_vlan.py: race condition
> >   quantum_adapter: race between ovs port deletion and plugin port
> >     deletion
> >   app/quantum_adapter: pylint
> >   controller/network: pylint
> >   app/simple_vlan: pylint
> > 
> >  ryu/app/gre_tunnel.py      |   11 +++++------
> >  ryu/app/quantum_adapter.py |   31 ++++++++++++++++++++++---------
> >  ryu/app/simple_vlan.py     |    4 +---
> >  ryu/controller/network.py  |   38 ++++++++++++++++++++++++++------------
> >  4 files changed, 54 insertions(+), 30 deletions(-)
> 
> I wait for the confirmation that this fixes the reported bug.

Wei-Ting Lin, I pushed the branch for your convenience at
git://github.com/yamahata/ryu.git race-fix-july-12-2013


> I've applied only trivial patches (#11 and #12). #10 is trivial too
> can not be applied cleanly.

Here is the rebased one.

>From 508149dd92a7d5fa9a2fa530c519f211483decdb Mon Sep 17 00:00:00 2001
Message-Id: 
<508149dd92a7d5fa9a2fa530c519f211483decdb.1373593289.git.yamah...@valinux.co.jp>
In-Reply-To: <[email protected]>
References: <[email protected]>
From: Isaku Yamahata <[email protected]>
Date: Wed, 26 Jun 2013 13:48:16 +0900
Subject: [PATCH] app/quantum_adapter: pylint

W: 18,0: Unused import logging
W: 28,0: Unused import event

Signed-off-by: Isaku Yamahata <[email protected]>
---
 ryu/app/quantum_adapter.py |    2 --
 1 file changed, 2 deletions(-)

diff --git a/ryu/app/quantum_adapter.py b/ryu/app/quantum_adapter.py
index cc2fa44..464937e 100644
--- a/ryu/app/quantum_adapter.py
+++ b/ryu/app/quantum_adapter.py
@@ -15,7 +15,6 @@
 # limitations under the License.
 
 from oslo.config import cfg
-import logging
 
 try:
     from neutronclient import client as q_client
@@ -35,7 +34,6 @@ from ryu.app import rest_nw_id
 from ryu.base import app_manager
 from ryu.controller import (conf_switch,
                             dpset,
-                            event,
                             handler,
                             network)
 from ryu.lib import dpid as dpid_lib
-- 
1.7.10.4

-- 
yamahata

------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
Ryu-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ryu-devel

Reply via email to