On Tue, 16 Jul 2013 10:41:06 +0900 (JST) [email protected] (YAMAMOTO Takashi) wrote:
>> On Tue, 2 Jul 2013 11:13:41 +0900 >> YAMAMOTO Takashi <[email protected]> wrote: >> >>> this set includes OFPxxx json representation functionality >>> >>> changes from the previous set: >>> rebase >>> fix 1-1-ofp_packet_out.packet.json >>> remove some commented out code >>> >>> YAMAMOTO Takashi (14): >>> StringifyMixin: json support >>> of-wire json: adapt OF1.0 >>> of-wire json: adapt OF1.0 nicira extention >>> of-wire json: adapt OF1.2 >>> ofproto_v1_2_parser: omit mask attribute from str() when appropriate >>> of-wire json: adapt OF1.3 >>> ofproto_v1_3_parser: omit mask attribute from str() when appropriate >>> test_parser_v12: abuse this to test to_jsondict and from_jsondict >>> add a test for ryu.lib.stringify >>> of-wire json test: expected results >>> of-wire json test: a program to generate test data for unit tests >>> of-wire json test: change the of_protocol upstream >>> of-wire json test: generated data for unit test >>> of-wire json test: unit test >> >> Thanks, I've applied #1, 2, 4, 5, 6, 7, 8, and 9 patches. >> >> I dropped #3 since I prefer nothing than incomplete (not tested). >> >> About the testing code, I want to avoid non python code. Also I think >> that we should not have binary data in our source. Can we put of-wire >> binary data on somewhere (e.g. our wiki) and add the testing code to >> download and test them? > > what problem do you have with binary files? I don't like to put binary into source code. Of-wire binary data will not changed so I don't see advantage of putting it into out git repo. > avoiding non python code is nice, but IMO keeping it in sync with > the tested code outwight the disadvantage. > > YAMAMOTO Takashi ------------------------------------------------------------------------------ See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
