On Wed, 24 Jul 2013 10:11:19 +0900 Yuichi Ito <[email protected]> wrote:
> On Wed, 24 Jul 2013 03:50:17 +0900 > FUJITA Tomonori <[email protected]> wrote: > > > On Mon, 22 Jul 2013 10:53:05 +0900 > > Yuichi Ito <[email protected]> wrote: > > > >> Changes v2 -> v3: > >> > >> - skip parsing the unknowns subtypes > >> - some minor fixes > >> > >> Signed-off-by: Yuichi Ito <[email protected]> > >> --- > >> doc/source/library_packet_ref.rst | 5 + > >> ryu/lib/packet/slow.py | 577 +++++++++++++++++++ > >> ryu/lib/packet/vlan.py | 2 + > >> ryu/tests/unit/packet/test_slow.py | 1096 > >> ++++++++++++++++++++++++++++++++++++ > >> 4 files changed, 1680 insertions(+) > >> create mode 100755 ryu/lib/packet/slow.py > >> create mode 100755 ryu/tests/unit/packet/test_slow.py > > > > I've fixed the following pep8 warnings and applied. Thanks. > > > > ryu/tests/unit/packet/test_slow.py:146:55: E225 missing whitespace > > around operator > > not_implemented_buf = str(SLOW_SUBTYPE_MARKER)+self.buf[1:] > > ^ > > ryu/tests/unit/packet/test_slow.py:153:29: E225 missing whitespace > > around operator > > invalid_buf = "\xff"+self.buf[1:] > > > > thank you for your remediation and application. > but my pep8 (version 1.4.6) does not report the above warnings. > could you tell me the pep8 version you used? Oops, my bad. 0.6.1. Too old, I guess. ------------------------------------------------------------------------------ See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
