Hi FUJITA-san
Thank you for the suggestion.
2013/7/26 FUJITA Tomonori <[email protected]>
> On Thu, 25 Jul 2013 12:41:49 +0900
> Satoshi Kobayashi <[email protected]> wrote:
>
> > Hi all,
> >
> > I tried to work Ryu by CentOS 6.4 which has Python 2.6.6 by default.
> Since
> > there was no argparse, it did not launch. IMHO, if Ryu supports
> > Python2.6.X, the following patches are required.
> >
> > ----------8<----------8<----------
> > diff --git a/setup.py b/setup.py
> > index 55c2660..1825984 100644
> > --- a/setup.py
> > +++ b/setup.py
> > @@ -24,6 +24,12 @@ from ryu import utils
> >
> > requires = utils.parse_requirements()
> >
> > +try:
> > + import argparse
> > +except ImportError:
> > + # for Python 2.6 or before
> > + requires.append('argparse')
> > +
> > doing_bdist = any(arg.startswith('bdist') for arg in sys.argv[1:])
> >
> > long_description = open('README.rst').read() + '\n\n'
> > ---------->8---------->8----------
>
> I think that we already have a trick in parse_requirements in utils.py
> for this. Simply adding 'argparse' doesn't work?
>
I checked the code and understood. IMHO, 'argparse' should be contained in
'tools/pip-requires' on every environment because there is this trick.
But this issue is solved with the patch of oslo.config sent at the point
(*1) because oslo.config has this trick itself. That is, after the above
mentioned patch is applying in, we may delete the trick.
*1: [PATCH] Remove contrib/oslo directory
Should I have included this in the same patch...?
Thanks,
Satoshi
------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
Ryu-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ryu-devel
