On Mon, 12 Aug 2013 09:49:37 +0900 (JST) FUJITA Tomonori <[email protected]> wrote:
> On Mon, 12 Aug 2013 09:47:19 +0900 (JST) > [email protected] (YAMAMOTO Takashi) wrote: > >>> On Wed, 7 Aug 2013 16:13:14 +0900 >>> YAMAMOTO Takashi <[email protected]> wrote: >>> >>>> following the recent OFPMatch api changes, >>>> this set changes OFPActionSetField api. >>>> >>>> for now, compatibility with the old api is maintained. >>>> >>>> old api: >>>> ofproto_v1_3_parser.OFPActionSetField(ofproto_v1_3_parser.MTInPort( >>>> ofproto_v1_3.OXM_OF_IN_PORT, 1)) >>>> >>>> new api: >>>> ofproto_v1_3_parser.OFPActionSetField("in_port", 1) >>> >>> Looks inconsistent with the new match API? >>> >>> OFPMatch(in_port=1) >>> >>> Then why not >>> >>> OFPActionSetField(in_port=1) >>> >>> ? >> >> because set-field uses only one oxm tlv. > > I know but still looks inconsistent. > > If we do > > OFPActionSetField("in_port", 1) > > Why not? > > OFPMatch("in_port"=1) My point is that both OFPActionSetField and OFPMatch handle oxm tlv(s). So I think that we had better to make the API for both consistent. ------------------------------------------------------------------------------ Get 100% visibility into Java/.NET code with AppDynamics Lite! It's a free troubleshooting tool designed for production. Get down to code-level detail for bottlenecks, with <2% overhead. Download for free and get started troubleshooting in minutes. http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
