Hi Ohmura-san,
Thank you for your review.
ofctl_* is very useful and my favorite.
Thanks!
Satoshi
2013/8/20 Kei Ohmura <[email protected]>
> Sorry, it's my mistake. The below patch looks good to me.
>
> 2013/8/8 Satoshi Kobayashi <[email protected]>:
> >
> > Signed-off-by: Satoshi Kobayashi <[email protected]>
> > ---
> > ryu/lib/ofctl_v1_0.py | 2 +-
> > ryu/lib/ofctl_v1_2.py | 2 +-
> > ryu/lib/ofctl_v1_3.py | 2 +-
> > 3 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/ryu/lib/ofctl_v1_0.py b/ryu/lib/ofctl_v1_0.py
> > index 58e2750..e68d53e 100644
> > --- a/ryu/lib/ofctl_v1_0.py
> > +++ b/ryu/lib/ofctl_v1_0.py
> > @@ -285,7 +285,7 @@ def mod_flow_entry(dp, flow, cmd):
> > flags = int(flow.get('flags', 0))
> > idle_timeout = int(flow.get('idle_timeout', 0))
> > hard_timeout = int(flow.get('hard_timeout', 0))
> > - actions = to_actions(dp, flow.get('actions', {}))
> > + actions = to_actions(dp, flow.get('actions', []))
> > match = to_match(dp, flow.get('match', {}))
> >
> > flow_mod = dp.ofproto_parser.OFPFlowMod(
> > diff --git a/ryu/lib/ofctl_v1_2.py b/ryu/lib/ofctl_v1_2.py
> > index 186c8a6..517b36a 100644
> > --- a/ryu/lib/ofctl_v1_2.py
> > +++ b/ryu/lib/ofctl_v1_2.py
> > @@ -249,7 +249,7 @@ def mod_flow_entry(dp, flow, cmd):
> > out_group = int(flow.get('out_group', dp.ofproto.OFPG_ANY))
> > flags = int(flow.get('flags', 0))
> > match = to_match(dp, flow.get('match', {}))
> > - inst = to_actions(dp, flow.get('actions', {}))
> > + inst = to_actions(dp, flow.get('actions', []))
> >
> > flow_mod = dp.ofproto_parser.OFPFlowMod(
> > dp, cookie, cookie_mask, table_id, cmd, idle_timeout,
> > diff --git a/ryu/lib/ofctl_v1_3.py b/ryu/lib/ofctl_v1_3.py
> > index bd11112..c67cde1 100644
> > --- a/ryu/lib/ofctl_v1_3.py
> > +++ b/ryu/lib/ofctl_v1_3.py
> > @@ -254,7 +254,7 @@ def mod_flow_entry(dp, flow, cmd):
> > out_group = int(flow.get('out_group', dp.ofproto.OFPG_ANY))
> > flags = int(flow.get('flags', 0))
> > match = to_match(dp, flow.get('match', {}))
> > - inst = to_actions(dp, flow.get('actions', {}))
> > + inst = to_actions(dp, flow.get('actions', []))
> >
> > flow_mod = dp.ofproto_parser.OFPFlowMod(
> > dp, cookie, cookie_mask, table_id, cmd, idle_timeout,
> > --
> > 1.7.1
>
--
Satoshi Kobayashi <[email protected]>
------------------------------------------------------------------------------
Introducing Performance Central, a new site from SourceForge and
AppDynamics. Performance Central is your source for news, insights,
analysis and resources for efficient Application Performance Management.
Visit us today!
http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
_______________________________________________
Ryu-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ryu-devel
