> On Tue, 27 Aug 2013 12:20:09 +0900 (JST) > [email protected] (YAMAMOTO Takashi) wrote: > >>> Signed-off-by: FUJITA Tomonori <[email protected]> >>> --- >>> ryu/ofproto/ofproto_v1_2_parser.py | 10 +++++++--- >>> 1 file changed, 7 insertions(+), 3 deletions(-) >>> >>> diff --git a/ryu/ofproto/ofproto_v1_2_parser.py >>> b/ryu/ofproto/ofproto_v1_2_parser.py >>> index 3ad700d..d1793af 100644 >>> --- a/ryu/ofproto/ofproto_v1_2_parser.py >>> +++ b/ryu/ofproto/ofproto_v1_2_parser.py >>> @@ -407,9 +407,13 @@ class OFPPacketOut(MsgBase): >>> >>> @_set_msg_type(ofproto_v1_2.OFPT_FLOW_MOD) >>> class OFPFlowMod(MsgBase): >>> - def __init__(self, datapath, cookie, cookie_mask, table_id, command, >>> - idle_timeout, hard_timeout, priority, buffer_id, out_port, >>> - out_group, flags, match, instructions): >>> + def __init__(self, datapath, cookie=0, cookie_mask=0, table_id=0, >>> + command=ofproto_v1_2.OFPFC_ADD, >>> + idle_timeout=0, hard_timeout=0, priority=0, >>> + buffer_id=ofproto_v1_2.OFP_NO_BUFFER, >>> + out_port=0, out_group=0, flags=0, >>> + match=None, >>> + instructions=[]): >>> super(OFPFlowMod, self).__init__(datapath) >>> self.cookie = cookie >>> self.cookie_mask = cookie_mask >> >> how about: >> >> if match is None: >> match = OFPMatch() > > ok.
looks good to me. thanks. YAMAMOTO Takashi > > diff --git a/ryu/ofproto/ofproto_v1_2_parser.py > b/ryu/ofproto/ofproto_v1_2_parser.py > index 3ad700d..833f17b 100644 > --- a/ryu/ofproto/ofproto_v1_2_parser.py > +++ b/ryu/ofproto/ofproto_v1_2_parser.py > @@ -407,9 +407,13 @@ class OFPPacketOut(MsgBase): > > @_set_msg_type(ofproto_v1_2.OFPT_FLOW_MOD) > class OFPFlowMod(MsgBase): > - def __init__(self, datapath, cookie, cookie_mask, table_id, command, > - idle_timeout, hard_timeout, priority, buffer_id, out_port, > - out_group, flags, match, instructions): > + def __init__(self, datapath, cookie=0, cookie_mask=0, table_id=0, > + command=ofproto_v1_2.OFPFC_ADD, > + idle_timeout=0, hard_timeout=0, priority=0, > + buffer_id=ofproto_v1_2.OFP_NO_BUFFER, > + out_port=0, out_group=0, flags=0, > + match=None, > + instructions=[]): > super(OFPFlowMod, self).__init__(datapath) > self.cookie = cookie > self.cookie_mask = cookie_mask > @@ -422,6 +426,8 @@ class OFPFlowMod(MsgBase): > self.out_port = out_port > self.out_group = out_group > self.flags = flags > + if match is None: > + match = OFPMatch() > self.match = match > self.instructions = instructions > > > ------------------------------------------------------------------------------ > Introducing Performance Central, a new site from SourceForge and > AppDynamics. Performance Central is your source for news, insights, > analysis and resources for efficient Application Performance Management. > Visit us today! > http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk > _______________________________________________ > Ryu-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/ryu-devel ------------------------------------------------------------------------------ Introducing Performance Central, a new site from SourceForge and AppDynamics. Performance Central is your source for news, insights, analysis and resources for efficient Application Performance Management. Visit us today! http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
