Hello Yamamoto,
I have submitted a pull request in Github. All the tests are working. ( I
had to modify some of them to accommodate for the new changes, the tests
that I changed are merely the ones that were testing "packet" library
behavior, the rest of the tests are the same. )
https://github.com/osrg/ryu/pull/15
Best,
Omid
On Mon, Sep 9, 2013 at 1:33 AM, YAMAMOTO Takashi <[email protected]>wrote:
> hi,
>
> > Hello Yamamoto,
> >
> > I will try to explain my problem with the current code in Ryu:
> >
> > When you parse a packet, MAC and IP fields get translated into EUI-64 and
> > dotted format for "no reason". This has a huge impact on performance when
> > you have a large number of packets (As it's obvious in the benchmark
> > code.). Ryu's packet library "is" slower than dpkt by a factor of 5 for
> > unpacking and 7 for packing because of this translation.
>
> thanks for explanation.
>
> >
> > My proposed solution is to remove automatic translation of IP and MAC
> > addresses into their human readable format, and make it a "lazy"
> > translation wherever it is necessary. (To be honest, I do not quite
> > understand where a dotted notation would be more beneficial than the byte
> > array, beside for humans.)
>
> yes, it's merely for humans' benefit.
>
> do you mean to use @property?
>
> >
> > Again, I can submit a code/patch if you would like to see my proposed
> > solution.
>
> i'm interested in it. as far as it doesn't make the code too complex.
>
> btw, can you keep mailing list cc:? thanks.
>
> YAMAMOTO Takashi
>
> >
> > Best,
> > Omid
>
------------------------------------------------------------------------------
How ServiceNow helps IT people transform IT departments:
1. Consolidate legacy IT systems to a single system of record for IT
2. Standardize and globalize service processes across IT
3. Implement zero-touch automation to replace manual, redundant tasks
http://pubads.g.doubleclick.net/gampad/clk?id=51271111&iu=/4140/ostg.clktrk
_______________________________________________
Ryu-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ryu-devel
