[Ryu-devel] [PATCH 1/4] packet lib: sctp: reduce computation

[Yuichi Ito]

Signed-off-by: Yuichi Ito <ito.yuic...@gmail.com>
---
 ryu/lib/packet/sctp.py |   46 ++++++++++++++++++++++++----------------------
 1 file changed, 24 insertions(+), 22 deletions(-)

diff --git a/ryu/lib/packet/sctp.py b/ryu/lib/packet/sctp.py
index e935c63..258dd18 100644
--- a/ryu/lib/packet/sctp.py
+++ b/ryu/lib/packet/sctp.py
@@ -1139,8 +1139,9 @@ class cause(stringify.StringifyMixin):

     def __len__(self):
         length = self.length
-        if length % 4:
-            length += 4 - length % 4
+        mod = length % 4
+        if mod:
+            length += 4 - mod
         return length


@@ -1166,9 +1167,9 @@ class cause_with_value(cause):
             self._PACK_STR, self.cause_code(), self.length))
         if self.value:
             buf.extend(self.value)
-        if len(buf) % 4:
-            padsize = 4 - len(buf) % 4
-            buf.extend(bytearray(padsize))
+        mod = len(buf) % 4
+        if mod:
+            buf.extend(bytearray(4 - mod))
         return str(buf)


@@ -1269,9 +1270,9 @@ class cause_missing_param(cause):
             self._PACK_STR, self.cause_code(), self.length, self.num))
         for one in self.types:
             buf.extend(struct.pack('!H', one))
-        if len(buf) % 4:
-            padsize = 4 - len(buf) % 4
-            buf.extend(bytearray(padsize))
+        mod = len(buf) % 4
+        if mod:
+            buf.extend(bytearray(4 - mod))
         return str(buf)


@@ -1398,9 +1399,9 @@ class cause_unresolvable_addr(cause_with_value):
             self._PACK_STR, self.cause_code(), self.length))
         if self.value:
             buf.extend(self.value.serialize())
-        if len(buf) % 4:
-            padsize = 4 - len(buf) % 4
-            buf.extend(bytearray(padsize))
+        mod = len(buf) % 4
+        if mod:
+            buf.extend(bytearray(4 - mod))
         return str(buf)


@@ -1633,9 +1634,9 @@ class cause_restart_with_new_addr(cause_with_value):
             self._PACK_STR, self.cause_code(), self.length))
         for one in self.value:
             buf.extend(one.serialize())
-        if len(buf) % 4:
-            padsize = 4 - len(buf) % 4
-            buf.extend(bytearray(padsize))
+        mod = len(buf) % 4
+        if mod:
+            buf.extend(bytearray(4 - mod))
         return str(buf)


@@ -1729,15 +1730,16 @@ class param(stringify.StringifyMixin):
             self._PACK_STR, self.param_type(), self.length))
         if self.value:
             buf.extend(self.value)
-        if len(buf) % 4:
-            padsize = 4 - len(buf) % 4
-            buf.extend(bytearray(padsize))
+        mod = len(buf) % 4
+        if mod:
+            buf.extend(bytearray(4 - mod))
         return str(buf)

     def __len__(self):
         length = self.length
-        if length % 4:
-            length += 4 - length % 4
+        mod = length % 4
+        if mod:
+            length += 4 - mod
         return length


@@ -1976,9 +1978,9 @@ class param_supported_addr(param):
             self._PACK_STR, self.param_type(), self.length))
         for one in self.value:
             buf.extend(struct.pack(param_supported_addr._VALUE_STR, one))
-        if len(buf) % 4:
-            padsize = 4 - len(buf) % 4
-            buf.extend(bytearray(padsize))
+        mod = len(buf) % 4
+        if mod:
+            buf.extend(bytearray(4 - mod))
         return str(buf)


-- 
1.7.10.4


------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from 
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk
_______________________________________________
Ryu-devel mailing list
Ryu-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ryu-devel