> On Fri, 1 Nov 2013 10:57:40 +0900 > YAMAMOTO Takashi <[email protected]> wrote: > >> please execute tools/normalize_json.py before committing *.json changes. > > Can you add a doc on it (what it is, for what we use these jsons, etc > )?
ok, i will. > > >> Signed-off-by: YAMAMOTO Takashi <[email protected]> >> --- >> ryu/tests/unit/ofproto/json/of13/4-50-ofp_meter_stats_reply.packet.json | 2 >> +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git >> a/ryu/tests/unit/ofproto/json/of13/4-50-ofp_meter_stats_reply.packet.json >> b/ryu/tests/unit/ofproto/json/of13/4-50-ofp_meter_stats_reply.packet.json >> index 50d295c..b4fd822 100644 >> --- a/ryu/tests/unit/ofproto/json/of13/4-50-ofp_meter_stats_reply.packet.json >> +++ b/ryu/tests/unit/ofproto/json/of13/4-50-ofp_meter_stats_reply.packet.json >> @@ -15,7 +15,7 @@ >> "duration_nsec": 480000, >> "duration_sec": 0, >> "flow_count": 0, >> - "len": 56, >> + "len": 56, > > The difference is a tailing white space? Then, the comparison code had > better ignore? The format doesn't matter. The contents matter. unit tests are not affected by whitespaces. the normalization is merely to make diffs easier to read. YAMAMOTO Takashi > > >> "meter_id": 100, >> "packet_in_count": 0 >> } >> -- >> 1.8.3.1 >> >> >> ------------------------------------------------------------------------------ >> Android is increasing in popularity, but the open development platform that >> developers love is also attractive to malware creators. Download this white >> paper to learn more about secure code signing practices that can help keep >> Android apps secure. >> http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk >> _______________________________________________ >> Ryu-devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/ryu-devel > > ------------------------------------------------------------------------------ > Android is increasing in popularity, but the open development platform that > developers love is also attractive to malware creators. Download this white > paper to learn more about secure code signing practices that can help keep > Android apps secure. > http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk > _______________________________________________ > Ryu-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/ryu-devel ------------------------------------------------------------------------------ Android is increasing in popularity, but the open development platform that developers love is also attractive to malware creators. Download this white paper to learn more about secure code signing practices that can help keep Android apps secure. http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
