> On Fri, 22 Nov 2013 16:45:59 +0900 > YAMAMOTO Takashi <yamam...@valinux.co.jp> wrote: > >> From: Isaku Yamahata <yamah...@valinux.co.jp> >> >> allow RyuManager to create/destroy RyuApp instances dynamically >> and register/unregister event observer dynamically. >> >> Cc: yuta-hamada <yuta.hamada....@gimal.com> >> Signed-off-by: Isaku Yamahata <yamah...@valinux.co.jp> >> Signed-off-by: YAMAMOTO Takashi <yamam...@valinux.co.jp> >> --- >> ryu/base/app_manager.py | 121 >> ++++++++++++++++++++++++++++++++----------- >> ryu/controller/controller.py | 2 +- >> 2 files changed, 93 insertions(+), 30 deletions(-) > > It turned out that this causes a regression.
because you dropped controller.py part of the patch. YAMAMOTO Takashi > > I've merged the following: > > == >>From cafb17781b0666f88dc9cddd24c3e2f946062b46 Mon Sep 17 00:00:00 2001 > From: FUJITA Tomonori <fujita.tomon...@lab.ntt.co.jp> > Date: Fri, 22 Nov 2013 22:04:16 -0800 > Subject: [PATCH] fix the regression due to > e45f382e51c9a3d57a6d8c01cec9e70f7ca364fd > > OFcontroller is not started due to: > > e45f382e51c9a3d57a6d8c01cec9e70f7ca364fd > Author: Isaku Yamahata <yamah...@valinux.co.jp> > Date: Fri Nov 22 16:45:59 2013 +0900 > > Signed-off-by: FUJITA Tomonori <fujita.tomon...@lab.ntt.co.jp> > --- > ryu/controller/controller.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ryu/controller/controller.py b/ryu/controller/controller.py > index 2bb43f9..5d71d3c 100644 > --- a/ryu/controller/controller.py > +++ b/ryu/controller/controller.py > @@ -325,6 +325,6 @@ def datapath_connection_factory(socket, address): > > > def start_service(app_mgr): > - for app in app_mgr.applications: > - if app.endswith('ofp_handler'): > + for app in app_mgr.applications.values(): > + if app.__class__.__name__.endswith('OFPHandler'): > return OpenFlowController() > -- > 1.8.3.4 (Apple Git-47) > > > ------------------------------------------------------------------------------ > Shape the Mobile Experience: Free Subscription > Software experts and developers: Be at the forefront of tech innovation. > Intel(R) Software Adrenaline delivers strategic insight and game-changing > conversations that shape the rapidly evolving mobile landscape. Sign up now. > http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk > _______________________________________________ > Ryu-devel mailing list > Ryu-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/ryu-devel ------------------------------------------------------------------------------ Shape the Mobile Experience: Free Subscription Software experts and developers: Be at the forefront of tech innovation. Intel(R) Software Adrenaline delivers strategic insight and game-changing conversations that shape the rapidly evolving mobile landscape. Sign up now. http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk _______________________________________________ Ryu-devel mailing list Ryu-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ryu-devel