On Wed, 27 Nov 2013 10:21:58 +0900 (JST) FUJITA Tomonori <[email protected]> wrote:
> On Wed, 27 Nov 2013 09:54:12 +0900 (JST) > [email protected] (YAMAMOTO Takashi) wrote: > > >> On Wed, 27 Nov 2013 09:19:14 +0900 (JST) > >> [email protected] (YAMAMOTO Takashi) wrote: > >> > >>>> sysfs is architecture independent. > >>>> > >>>> Signed-off-by: FUJITA Tomonori <[email protected]> > >>>> --- > >>>> ryu/services/protocols/vrrp/monitor_linux.py | 40 > >>>> +++------------------------- > >>>> 1 file changed, 4 insertions(+), 36 deletions(-) > >>>> > >>>> diff --git a/ryu/services/protocols/vrrp/monitor_linux.py > >>>> b/ryu/services/protocols/vrrp/monitor_linux.py > >>>> index f1b5efb..2c3569e 100644 > >>>> --- a/ryu/services/protocols/vrrp/monitor_linux.py > >>>> +++ b/ryu/services/protocols/vrrp/monitor_linux.py > >>>> @@ -14,12 +14,7 @@ > >>>> # See the License for the specific language governing permissions and > >>>> # limitations under the License. > >>>> > >>>> -# tested on 64bit linux. > >>>> -# On other platform like 32bit Linux, the structure can be different > >>>> -# due to alignment difference. > >>> > >>> have you taken a look at _join_vrrp_group? > >> > >> The structures used in the function is defined in RFC and are aligned > >> properly in every architectures? > > > > they look so. if they are, please add a comment. > > Ok, how about the following? > > >From 872926964e22e7b3de1aee92b74ecaee7b92b404 Mon Sep 17 00:00:00 2001 > From: FUJITA Tomonori <[email protected]> > Date: Tue, 26 Nov 2013 17:23:22 -0800 > Subject: [PATCH v2] vrrp: use sysfs instead of ioctl to get ifindex > > sysfs is architecture independent. > > Signed-off-by: FUJITA Tomonori <[email protected]> > --- > ryu/services/protocols/vrrp/monitor_linux.py | 48 > +++++++--------------------- > 1 file changed, 12 insertions(+), 36 deletions(-) Applied. ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
