>> On Tue, Jan 21, 2014 at 02:35:33PM +0900, YAMAMOTO Takashi wrote:
>>> > * A patch on top to make the v5 code use the 3-argument
>>> > version of cut_bits() added in Yamamoto-san's v4-ext branch.
>>>
>>> probably send a pull request for v5 branch?
>>
>> Unfortunately I don't think there is a branch which contains the
>> pre-requisites for this change.
>>
>> * The v5 branch doesn't have your patch to add the third argument to
>> cut_bits() and;
>
> cut_bits stuff has been merged to master recently. (commit 202a5afc)
ah, i got it. master has it but v5 doesn't.
you can send a pullup as "merge master to v5" + your patch.
but it might be better to wait for LINC folks syncing branches
in some way.
YAMAMOTO Takashii
>
> YAMAMOTO Takashi
>
>> * Your v4-ext branch doesn't have OF1.4 (=v5) support
>>
>>>
>>> > + tx_bytes = 336,rx_dropped = 0,tx_dropped = 0,
>>> > + rx_errors = 0, tx_errors = 0,
>>> > + properties =
>>> > + [#ofp_port_stats_prop_ethernet{
>>> > + rx_frame_err = 0,rx_over_err = 0,
>>> > + rx_crc_err = 0,collisions = 0}]},
>>> > + #ofp_port_stats{
>>> > + port_no = 6,rx_packets = 4,tx_packets = 4,rx_bytes
>>> > = 336,
>>> > + tx_bytes = 336,rx_dropped = 0,tx_dropped = 0,
>>> > + rx_errors = 0, tx_errors = 0,
>>> > + properties =
>>> > + [#ofp_port_stats_prop_ethernet{
>>> > + rx_frame_err = 0,rx_over_err = 0,
>>> > + rx_crc_err = 0,collisions = 0}]}]},
>>>
>>> please expand tabs.
>>> otherwise looks good to me.
>>
>> Sure, will do.
>
> ------------------------------------------------------------------------------
> CenturyLink Cloud: The Leader in Enterprise Cloud Services.
> Learn Why More Businesses Are Choosing CenturyLink Cloud For
> Critical Workloads, Development Environments & Everything In Between.
> Get a Quote or Start a Free Trial Today.
> http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
> _______________________________________________
> Ryu-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/ryu-devel
------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today.
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________
Ryu-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ryu-devel
