> On Tue, 28 Jan 2014 11:31:07 +0900 > YAMAMOTO Takashi <[email protected]> wrote: > >> As this would be 0x8100 in most cases, make it the default. >> >> Signed-off-by: YAMAMOTO Takashi <[email protected]> >> --- >> ryu/ofproto/ofproto_v1_2_parser.py | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/ryu/ofproto/ofproto_v1_2_parser.py >> b/ryu/ofproto/ofproto_v1_2_parser.py >> index 39a4e30..f24c69b 100644 >> --- a/ryu/ofproto/ofproto_v1_2_parser.py >> +++ b/ryu/ofproto/ofproto_v1_2_parser.py >> @@ -1348,7 +1348,7 @@ class OFPActionPushVlan(OFPAction): >> ethertype Ether type >> ================ ====================================================== >> """ >> - def __init__(self, ethertype, type_=None, len_=None): >> + def __init__(self, ethertype=0x8100, type_=None, len_=None): >> super(OFPActionPushVlan, self).__init__() >> self.ethertype = ethertype > > How about using ETH_TYPE_8021Q in ofproto/ether.py?
sure. i wasn't aware of the definition. i'll fix and repost. YAMAMOTO Takashi > > ------------------------------------------------------------------------------ > WatchGuard Dimension instantly turns raw network data into actionable > security intelligence. It gives you real-time visual feedback on key > security issues and trends. Skip the complicated setup - simply import > a virtual appliance and go from zero to informed in seconds. > http://pubads.g.doubleclick.net/gampad/clk?id=123612991&iu=/4140/ostg.clktrk > _______________________________________________ > Ryu-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/ryu-devel ------------------------------------------------------------------------------ WatchGuard Dimension instantly turns raw network data into actionable security intelligence. It gives you real-time visual feedback on key security issues and trends. Skip the complicated setup - simply import a virtual appliance and go from zero to informed in seconds. http://pubads.g.doubleclick.net/gampad/clk?id=123612991&iu=/4140/ostg.clktrk _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
