hi,
> > def set_app_supported_versions(vers):
> > - _versions &= set(vers)
> > - assert _versions, 'No OpenFlow version is available'
> > + global _supported_versions
> > +
> > + _supported_versions &= set(vers)
> > + assert _supported_versions, 'No OpenFlow version is available'
>
>
> Hi, the next error came out this time on your new patch
> in my local environment, when switch is connected.
thanks. i'm preparing a fix.
YAMAMOTO Takashi
>
>
> Error in the datapath None from ('127.0.0.1', 54964)
> hub: uncaught exception: Traceback (most recent call last):
> File "/usr/local/lib/python2.7/dist-packages/ryu/lib/hub.py", line 48, in
> _launch
> func(*args, **kwargs)
> File
> "/usr/local/lib/python2.7/dist-packages/ryu/controller/controller.py", line
> 295, in datapath_connection_factory
> datapath.serve()
> File
> "/usr/local/lib/python2.7/dist-packages/ryu/controller/controller.py", line
> 215, in serve
> self._recv_loop()
> File
> "/usr/local/lib/python2.7/dist-packages/ryu/controller/controller.py", line
> 93, in deactivate
> method(self)
> File
> "/usr/local/lib/python2.7/dist-packages/ryu/controller/controller.py", line
> 157, in _recv_loop
> handler(ev)
> File
> "/usr/local/lib/python2.7/dist-packages/ryu/controller/ofp_handler.py", line
> 77, in hello_handler
> datapath.supported_ofp_version)
> AttributeError: 'Datapath' object has no attribute 'supported_ofp_version'
>
>
>
>
> Is this right?
>
> @@ -50,6 +51,7 @@ class ProtocolDesc(object):
> if version is None:
> version = max(_supported_versions)
> self.set_version(version)
> + self.supported_ofp_version = _supported_versions
>
>
>
> thanks.
>
>
> On Thu, 6 Feb 2014 14:30:58 +0900
> YAMAMOTO Takashi <[email protected]> wrote:
>> fix the following crash.
>> from Yuichi Ito. minor editorialization by me.
>>
>>> Traceback (most recent call last):
>>> File "/usr/local/bin/ryu-manager", line 9, in <module>
>>> load_entry_point('ryu==3.6', 'console_scripts', 'ryu-manager')()
>>> File "/usr/local/lib/python2.7/dist-packages/ryu/cmd/manager.py", line
>>> 73, in main
>>> services.extend(app_mgr.instantiate_apps(**contexts))
>>> File "/usr/local/lib/python2.7/dist-packages/ryu/base/app_manager.py",
>>> line 368, in instantiate_apps
>>> self._instantiate(app_name, cls, *args, **kwargs)
>>> > File
>>> "/usr/local/lib/python2.7/dist-packages/ryu/base/app_manager.py", line 350,
>>> in _instantiate
>>> ofproto_protocol.set_app_supported_versions(cls.OFP_VERSIONS)
>>> File
>>> "/usr/local/lib/python2.7/dist-packages/ryu/ofproto/ofproto_protocol.py",
>>> line 40, in set_app_supported_versions
>>> _versions &= set(vers)
>>> UnboundLocalError: local variable '_versions' referenced before assignment
>>
>> Signed-off-by: YAMAMOTO Takashi <[email protected]>
>> ---
>> ryu/ofproto/ofproto_protocol.py | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/ryu/ofproto/ofproto_protocol.py
>> b/ryu/ofproto/ofproto_protocol.py
>> index cf0495d..d9ca997 100644
>> --- a/ryu/ofproto/ofproto_protocol.py
>> +++ b/ryu/ofproto/ofproto_protocol.py
>> @@ -37,8 +37,10 @@ _supported_versions = set(_versions.keys())
>>
>>
>> def set_app_supported_versions(vers):
>> - _versions &= set(vers)
>> - assert _versions, 'No OpenFlow version is available'
>> + global _supported_versions
>> +
>> + _supported_versions &= set(vers)
>> + assert _supported_versions, 'No OpenFlow version is available'
>>
>>
>> class ProtocolDesc(object):
>>
>
>
>
>
> ------------------------------------------------------------------------------
> Managing the Performance of Cloud-Based Applications
> Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
> Read the Whitepaper.
> http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk
> _______________________________________________
> Ryu-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/ryu-devel
------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk
_______________________________________________
Ryu-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ryu-devel
