When test tool receives a malformed packet(length value is unusual, for example), detecting differences between expected and received is a failure. In this case, 'Internal error.' is not suitable as a log message and should notify tool receives a malformed packet.
Signed-off-by: WATANABE Fumitaka <[email protected]> --- ryu/tests/switch/tester.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ryu/tests/switch/tester.py b/ryu/tests/switch/tester.py index 8556b52..4b2b42a 100644 --- a/ryu/tests/switch/tester.py +++ b/ryu/tests/switch/tester.py @@ -592,8 +592,8 @@ class OfTester(app_manager.RyuApp): if msg: return '/'.join(msg) else: - raise RyuException('Internal error.' - ' receive packet is matching.') + return ('Encounter an error during packet comparison.' + ' it is malformed.') def _wait(self): """ Wait until specific OFP message received -- 1.7.10.4 ------------------------------------------------------------------------------ Managing the Performance of Cloud-Based Applications Take advantage of what the Cloud has to offer - Avoid Common Pitfalls. Read the Whitepaper. http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
