On Tue, 18 Feb 2014 14:37:42 +0900
Hiroaki KAWAI <[email protected]> wrote:
> "The Pop PBB header action does not remove the backbone VLAN
> header (B-TAG)" as described in openflow spec 1.3.3.
> The format of I-TAG TCI is pcp,..,I-SID,C-DA,C-SA as in
> 802.1Q-2011 Figure 9-3.
Thanks a lot! As you pointed out, the action should not remove B-TAG.
I have a question about the expected packet (I'm not familiar with
this area). The format of the packet (ether/t-tag/s-tag/c-tag/...) is
valid (used in the real world)?
I thought that it might be better to fix the 'ingress' packet format?
Another potentially fix might be pop_vlan before pop_pbb but currently
the action testes verify one action in general. With the following
patch, Trema and CPqD pass this test).
diff --git a/ryu/tests/switch/of13/action/27_POP_PBB.json
b/ryu/tests/switch/of13/action/27_POP_PBB.json
index 821d3c9..14216c1 100644
--- a/ryu/tests/switch/of13/action/27_POP_PBB.json
+++ b/ryu/tests/switch/of13/action/27_POP_PBB.json
@@ -1,7 +1,7 @@
[
"action: 27_POP_PBB",
{
- "description":
"ethernet/svlan/itag/ethernet/svlan/vlan/ipv4/tcp-->'eth_type=0x88e7,actions=pop_pbb,output:2'",
+ "description":
"ethernet/itag/ethernet/svlan/vlan/ipv4/tcp-->'eth_type=0x88e7,actions=pop_pbb,output:2'",
"prerequisite":[
{
"OFPFlowMod":{
@@ -41,8 +41,7 @@
"tests":[
{
"ingress":[
- "ethernet(dst='22:22:22:22:22:22',
src='11:11:11:11:11:11', ethertype=34984)",
- "svlan(ethertype=35047, vid=10)",
+ "ethernet(dst='22:22:22:22:22:22',
src='11:11:11:11:11:11', ethertype=35047)",
"itag(sid=100)",
"ethernet(dst='22:22:22:22:22:22',
src='11:11:11:11:11:11', ethertype=34984)",
"svlan(ethertype=33024, vid=10)",
@@ -63,7 +62,7 @@
]
},
{
- "description":
"ethernet/svlan/itag/ethernet/svlan/vlan/ipv6/tcp-->'eth_type=0x88e7,actions=pop_pbb,output:2'",
+ "description":
"ethernet/itag/ethernet/svlan/vlan/ipv6/tcp-->'eth_type=0x88e7,actions=pop_pbb,output:2'",
"prerequisite":[
{
"OFPFlowMod":{
@@ -103,8 +102,7 @@
"tests":[
{
"ingress":[
- "ethernet(dst='22:22:22:22:22:22',
src='11:11:11:11:11:11', ethertype=34984)",
- "svlan(ethertype=35047, vid=10)",
+ "ethernet(dst='22:22:22:22:22:22',
src='11:11:11:11:11:11', ethertype=35047)",
"itag(sid=100)",
"ethernet(dst='22:22:22:22:22:22',
src='11:11:11:11:11:11', ethertype=34984)",
"svlan(ethertype=33024, vid=10)",
@@ -125,7 +123,7 @@
]
},
{
- "description":
"ethernet/svlan/itag/ethernet/svlan/vlan/arp-->'eth_type=0x88e7,actions=pop_pbb,output:2'",
+ "description":
"ethernet/itag/ethernet/svlan/vlan/arp-->'eth_type=0x88e7,actions=pop_pbb,output:2'",
"prerequisite":[
{
"OFPFlowMod":{
@@ -165,8 +163,7 @@
"tests":[
{
"ingress":[
- "ethernet(dst='22:22:22:22:22:22',
src='11:11:11:11:11:11', ethertype=34984)",
- "svlan(ethertype=35047, vid=10)",
+ "ethernet(dst='22:22:22:22:22:22',
src='11:11:11:11:11:11', ethertype=35047)",
"itag(sid=100)",
"ethernet(dst='22:22:22:22:22:22',
src='11:11:11:11:11:11', ethertype=34984)",
"svlan(ethertype=33024, vid=10)",
------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121054471&iu=/4140/ostg.clktrk
_______________________________________________
Ryu-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ryu-devel
