> On Wed, Feb 19, 2014 at 08:10:03PM +0900, FUJITA Tomonori wrote: >> On Wed, 19 Feb 2014 17:22:45 +0900 >> Simon Horman <[email protected]> wrote: >> >> > This will be used by at least the serialisation of >> > flow mod messages with properties. >> > >> > Signed-off-by: Simon Horman <[email protected]> >> > >> > --- >> > v2 >> > * first post >> > --- >> > ryu/ofproto/ofproto_v1_4_parser.py | 49 >> > +++++++++++++++++++++++++++++++++++--- >> > 1 file changed, 46 insertions(+), 3 deletions(-) >> > >> > diff --git a/ryu/ofproto/ofproto_v1_4_parser.py >> > b/ryu/ofproto/ofproto_v1_4_parser.py >> > index 26debbc..f270e23 100644 >> > --- a/ryu/ofproto/ofproto_v1_4_parser.py >> > +++ b/ryu/ofproto/ofproto_v1_4_parser.py >> > @@ -833,6 +833,15 @@ class OFPTableModPropEviction(StringifyMixin): >> > ofproto.OFP_TABLE_MOD_PROP_EVICTION_PACK_STR, buf, 0) >> > return eviction >> > >> > + def serialize(self): >> > + # fixup >> >> What needs to be fixed? > > I copied this pattern of #fixup in serialize() methods from the OF1.3. My > understanding, which may well be incorrect, is that it refers to fixing up > the length of the instance of the class as it may not have been initialised > if the instance was instantiated directly rather than via the parser.
i wrote these comments. your understanding is correct. YAMAMOTO Takashi > > In any case, I don't think there is any thing to fix and > I'm happy to remove this and other similar comments in the OF1.4 code. > > ------------------------------------------------------------------------------ > Managing the Performance of Cloud-Based Applications > Take advantage of what the Cloud has to offer - Avoid Common Pitfalls. > Read the Whitepaper. > http://pubads.g.doubleclick.net/gampad/clk?id=121054471&iu=/4140/ostg.clktrk > _______________________________________________ > Ryu-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/ryu-devel ------------------------------------------------------------------------------ Managing the Performance of Cloud-Based Applications Take advantage of what the Cloud has to offer - Avoid Common Pitfalls. Read the Whitepaper. http://pubads.g.doubleclick.net/gampad/clk?id=121054471&iu=/4140/ostg.clktrk _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
