On Thu, Feb 27, 2014 at 08:35:56AM +0900, FUJITA Tomonori wrote: > On Wed, 26 Feb 2014 15:58:01 +0900 > Simon Horman <[email protected]> wrote: > > > --- > > ryu/ofproto/ofproto_v1_3_parser.py | 16 ++++-------- > > .../of13/4-55-ofp_table_features_request.packet | Bin 11072 -> 11128 > > bytes > > ryu/tests/packet_data_generator/src/x4.erl | 14 +++++++++- > > .../4-55-ofp_table_features_request.packet.json | 29 > > ++++++++++++++++++++- > > 4 files changed, 46 insertions(+), 13 deletions(-) > > > > diff --git a/ryu/ofproto/ofproto_v1_3_parser.py > > b/ryu/ofproto/ofproto_v1_3_parser.py > > index 0ca4769..c05f90c 100644 > > --- a/ryu/ofproto/ofproto_v1_3_parser.py > > +++ b/ryu/ofproto/ofproto_v1_3_parser.py > > @@ -5126,7 +5126,7 @@ class OFPTableFeaturePropOxm(OFPTableFeatureProp): > > @OFPTableFeatureProp.register_type(ofproto.OFPTFPT_EXPERIMENTER_MISS) > > class OFPTableFeaturePropExperimenter(OFPTableFeatureProp): > > _DATA_ELEMENT_PACK_STR = '!I' > > - _PACK_STR = '!II' > > + _BODY_PACK_STR = '!II' > > > > def __init__(self, type_, experimenter=None, exp_type=None, > > data=None, length=None): > > @@ -5138,13 +5138,13 @@ class > > OFPTableFeaturePropExperimenter(OFPTableFeatureProp): > > > > @classmethod > > def _parse_prop(cls, buf): > > - (experimenter, exp_type) = struct.unpack_from(cls._PACK_STR, buf, > > 0) > > + (experimenter, exp_type) = struct.unpack_from(cls._BODY_PACK_STR, > > buf, 0) > > I got a pep8 warning: > > ryu/ofproto/ofproto_v1_3_parser.py:5141:80: E501 line too long (81 > > 79 characters) > (experimenter, exp_type) = > struct.unpack_from(cls._BODY_PACK_STR, buf, 0)
Sorry for letting that slip through. I'll repost the series. ------------------------------------------------------------------------------ Flow-based real-time traffic analytics software. Cisco certified tool. Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer Customize your own dashboards, set traffic alerts and generate reports. Network behavioral analysis & security monitoring. All-in-one tool. http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
