Hi, the aim of this series is to add an implementation of and tests for bundle control message and bundle add message.
A complication of implementing unit tests for bundle control add message is that they are OpenFlow messages that encapsulate an OpenFlow message. And thus some infrastructures changes are required: specifically to allow MsgBase subclasses at other than the top-level when parsing messages from JSON. The above complication does not affect bundle control message, only bundle add message. My first pass at this infrastructure changes is the 4rd patch of this series: "Allow messages inside messages". As I expect this change to require some discussion I have marked all bundle add message patches as RFC. This series depends on "[PATCH 0/7] of14: Add Flow monitor support" To aid review this series and its dependencies are available at https://github.com/horms/ryu devel/of1.4-bundle I have made a wiki page to summarise the status of OF1.4 support in Ryu https://github.com/horms/ryu/wiki/OpenFlow-V1.4-Coverage Simon Horman (5): of14: Add bundle control message support of14: Add bundle control message unit test [RFC] of14: Add bundle add message support [RFC] Allow messages inside messages [RFC] of14: Add bundle add message unit test ryu/lib/stringify.py | 20 ++-- ryu/ofproto/ofproto_parser.py | 1 - ryu/ofproto/ofproto_v1_4.py | 5 +- ryu/ofproto/ofproto_v1_4_parser.py | 124 +++++++++++++++++++++ .../of14/5-68-ofp_bundle_ctrl_msg.packet | Bin 0 -> 72 bytes .../of14/5-69-ofp_bundle_add_msg.packet | Bin 0 -> 80 bytes ryu/tests/packet_data_generator/src/x5.erl | 41 ++++++- .../json/of14/5-68-ofp_bundle_ctrl_msg.packet.json | 36 ++++++ .../json/of14/5-69-ofp_bundle_add_msg.packet.json | 41 +++++++ ryu/tests/unit/ofproto/test_parser.py | 2 + 10 files changed, 260 insertions(+), 10 deletions(-) create mode 100644 ryu/tests/packet_data/of14/5-68-ofp_bundle_ctrl_msg.packet create mode 100644 ryu/tests/packet_data/of14/5-69-ofp_bundle_add_msg.packet create mode 100644 ryu/tests/unit/ofproto/json/of14/5-68-ofp_bundle_ctrl_msg.packet.json create mode 100644 ryu/tests/unit/ofproto/json/of14/5-69-ofp_bundle_add_msg.packet.json -- 1.8.5.2 ------------------------------------------------------------------------------ Subversion Kills Productivity. Get off Subversion & Make the Move to Perforce. With Perforce, you get hassle-free workflows. Merge that actually works. Faster operations. Version large binaries. Built-in WAN optimization and the freedom to use Git, Perforce or both. Make the move to Perforce. http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
