On Tue, Mar 04, 2014 at 04:07:25PM +0900, YAMAMOTO Takashi wrote: > > On Tue, Mar 04, 2014 at 03:29:57PM +0900, FUJITA Tomonori wrote: > >> On Tue, 4 Mar 2014 12:07:36 +0900 (JST) > >> [email protected] (YAMAMOTO Takashi) wrote: > >> > >> > OFPPropCommonExperimenter4ByteData takes "data" of a list of words. > >> > others like OFPActionExperimenter and OFPErrorExperimenterMsg takes > >> > bytes. IMO it would be better to be consistent either way. > >> > i prefer bytes. > >> > >> Let's go with bytes. I guess that we've used bytes for such. Can you > >> send a patch? > > > > The reason that I chose a list of words as it seemed closes to > > the speck, which has an array of 32bit integers. > > > > I don't mind particularly how Ryu implements this. But I think it would be > > good to enforce that data must be a multiple of 4 bytes long (as I think > > the current implementation does). > > while the spec uses uint32_t, the comment above seems saying > 8-byte padding, allowing unaligned length. > (at least for ofp_table_mod_prop_experimenter. > i haven't checked other structures.)
True, it seems rather unclear what the intention is. I think its reasonable to just use bytes as you suggest. ------------------------------------------------------------------------------ Subversion Kills Productivity. Get off Subversion & Make the Move to Perforce. With Perforce, you get hassle-free workflows. Merge that actually works. Faster operations. Version large binaries. Built-in WAN optimization and the freedom to use Git, Perforce or both. Make the move to Perforce. http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
