Thank you for the comment. I fixed the patches. I’ll resend them soon. On Mar 21, 2014, at 20:39, FUJITA Tomonori <[email protected]> wrote:
> On Tue, 18 Mar 2014 09:53:37 +0000 > ISHIDA Wataru <[email protected]> wrote: > >> >> Signed-off-by: ISHIDA Wataru <[email protected]> >> --- >> ryu/app/ofctl_rest.py | 51 >> ++++++++++--------------------------------------- >> 1 file changed, 10 insertions(+), 41 deletions(-) >> >> diff --git a/ryu/app/ofctl_rest.py b/ryu/app/ofctl_rest.py >> index 9fbce30..5967d69 100644 >> --- a/ryu/app/ofctl_rest.py >> +++ b/ryu/app/ofctl_rest.py >> @@ -498,6 +498,16 @@ class RestStatsApi(app_manager.RyuApp): >> controller=StatsController, >> action='send_experimenter', >> conditions=dict(method=['POST'])) >> >> + @set_ev_cls(ofp_event.EventOFPStatsReply, MAIN_DISPATCHER) >> + @set_ev_cls(ofp_event.EventOFPDescStatsReply, MAIN_DISPATCHER) >> + @set_ev_cls(ofp_event.EventOFPFlowStatsReply, MAIN_DISPATCHER) >> + @set_ev_cls(ofp_event.EventOFPPortStatsReply, MAIN_DISPATCHER) >> + @set_ev_cls(ofp_event.EventOFPMeterStatsReply, MAIN_DISPATCHER) > > Sounds a good feature but @set_ev_cls supports the multi states like: > > @set_ev_cls(ofp_event.EventOFPStateChange, > [MAIN_DISPATCHER, DEAD_DISPATCHER]) > > So the following format is more consistent with what we have? > > @set_ev_cls([ofp_event.EventOFPStateChange, ofp_event.EventOFPStatsReply], > MAIN_DISPATCHER) > > >> + @set_ev_cls(ofp_event.EventOFPMeterFeaturesStatsReply, MAIN_DISPATCHER) >> + @set_ev_cls(ofp_event.EventOFPMeterConfigStatsReply, MAIN_DISPATCHER) >> + @set_ev_cls(ofp_event.EventOFPGroupStatsReply, MAIN_DISPATCHER) >> + @set_ev_cls(ofp_event.EventOFPGroupFeaturesStatsReply, MAIN_DISPATCHER) >> + @set_ev_cls(ofp_event.EventOFPGroupDescStatsReply, MAIN_DISPATCHER) >> def stats_reply_handler(self, ev): >> msg = ev.msg >> dp = msg.datapath >> @@ -521,44 +531,3 @@ class RestStatsApi(app_manager.RyuApp): >> return >> del self.waiters[dp.id][msg.xid] >> lock.set() >> - >> - @set_ev_cls(ofp_event.EventOFPStatsReply, MAIN_DISPATCHER) >> - def any_stats_reply_handler(self, ev): >> - # for OpenFlow 1.2 >> - self.stats_reply_handler(ev) >> - >> - @set_ev_cls(ofp_event.EventOFPDescStatsReply, MAIN_DISPATCHER) >> - def desc_stats_reply_handler(self, ev): >> - self.stats_reply_handler(ev) >> - >> - @set_ev_cls(ofp_event.EventOFPFlowStatsReply, MAIN_DISPATCHER) >> - def flow_stats_reply_handler(self, ev): >> - self.stats_reply_handler(ev) >> - >> - @set_ev_cls(ofp_event.EventOFPPortStatsReply, MAIN_DISPATCHER) >> - def port_stats_reply_handler(self, ev): >> - self.stats_reply_handler(ev) >> - >> - @set_ev_cls(ofp_event.EventOFPMeterStatsReply, MAIN_DISPATCHER) >> - def meter_stats_reply_handler(self, ev): >> - self.stats_reply_handler(ev) >> - >> - @set_ev_cls(ofp_event.EventOFPMeterFeaturesStatsReply, MAIN_DISPATCHER) >> - def meter_features_stats_reply_handler(self, ev): >> - self.stats_reply_handler(ev) >> - >> - @set_ev_cls(ofp_event.EventOFPMeterConfigStatsReply, MAIN_DISPATCHER) >> - def meter_config_stats_reply_handler(self, ev): >> - self.stats_reply_handler(ev) >> - >> - @set_ev_cls(ofp_event.EventOFPGroupStatsReply, MAIN_DISPATCHER) >> - def group_stats_reply_handler(self, ev): >> - self.stats_reply_handler(ev) >> - >> - @set_ev_cls(ofp_event.EventOFPGroupFeaturesStatsReply, MAIN_DISPATCHER) >> - def group_features_stats_reply_handler(self, ev): >> - self.stats_reply_handler(ev) >> - >> - @set_ev_cls(ofp_event.EventOFPGroupDescStatsReply, MAIN_DISPATCHER) >> - def group_desc_stats_reply_handler(self, ev): >> - self.stats_reply_handler(ev) >> -- >> 1.7.9.5 >> >> >> ------------------------------------------------------------------------------ >> Learn Graph Databases - Download FREE O'Reilly Book >> "Graph Databases" is the definitive new guide to graph databases and their >> applications. Written by three acclaimed leaders in the field, >> this first edition is now available. Download your free book today! >> http://p.sf.net/sfu/13534_NeoTech >> _______________________________________________ >> Ryu-devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/ryu-devel ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
