On Wed, 2 Apr 2014 13:11:49 +0900 (JST) [email protected] (YAMAMOTO Takashi) wrote:
>> On Wed, 26 Mar 2014 15:39:30 +0900 (JST) >> [email protected] (YAMAMOTO Takashi) wrote: >> >>>> On Wed, 26 Mar 2014 14:13:24 +0900 (JST) >>>> [email protected] (YAMAMOTO Takashi) wrote: >>>> >>>>>> On Wed, 26 Mar 2014 14:00:07 +0900 (JST) >>>>>> [email protected] (YAMAMOTO Takashi) wrote: >>>>>> >>>>>>>> On Wed, 26 Mar 2014 13:04:17 +0900 >>>>>>>> YAMAMOTO Takashi <[email protected]> wrote: >>>>>>>> >>>>>>>>> this will be used by ofctl app which registers handlers dynamically. >>>>>>>> >>>>>>>> Why ofctl needs to register handlers dynamically? >>>>>>> >>>>>>> because the interested set of OF replies events (EventOFPxxxReply) >>>>>>> depends on the consumer of the ofctl.api. >>>>>> >>>>>> EventOFPxxxReply is sent to ofctl only when ofctl sent the >>>>>> request. Having a handler to get all kinds of events from is simpler? >>>>> >>>>> ofctl app acts as a proxy which sends a request for ofctl.api consumer >>>>> app. ie. ofctl app does not know what requests it wants to send >>>>> (thus what replies it wants to listen) until actually requested by >>>>> the consumer app. >>>>> >>>>> we can have a handler with set_ev_cls listing all possible >>>>> EventOFPxxxReply and update the list whenever we implement >>>>> new OFP messages. but i don't consider it simpler. >>>> >>>> I meant that we can add a handler to all the kinds of handlers from >>>> ofp like: >>>> >>>> set_ev_cls(OFPAllEvents) >>>> def hoge() >>> >>> there are two steps to listen an event. >>> >>> a. put the consumer app into the provider's RyuApp.observers >>> b. set up the consumer's RyuApp.event_handlers >>> >>> which is your 'set_ev_cls(OFPAllEvents)' supposed to perform? >>> both? >> >> both only once at the startup. > > as i explained off-line, depending combination of apps, > it can affect performance badly. > i can implement your suggested way if you still prefer it, though. I'll review this soon. This and the 'ryu' command patchset could easily break everything so I avoided merging this just before the release. ------------------------------------------------------------------------------ _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
