Hi, thank you for reporting. I will cope with it. On Thu, 17 Apr 2014 09:27:09 +0800 arne_goetje <[email protected]> wrote:
> Dear Fujita san and Ito san, > > Thanks for the fix, however, it doesn't catch the VLAN mask yet, which is > 0x1FFF, so the 06_VLAN_VID and 07_VLAN_PCP tests (both match and action) > still fail. > > Another issue is the METADATA MASK... some switch hardware only supports a > partial mask, e.g. the BRCM Apollo2 chip only supports the 0x7FF mask, and > this mask is also returned by default. E.g. in the (match:) 02_METADATA > test the rule contains: "actions=write_metadata:255/0xffffffff", which the > switch returns the 0x7FF mask to: > "instructions=[OFPInstructionWriteMetadata(len=24,metadata=255,metadata_mask=2047,type=2)," > > How do you want to handle this case? Pass or Fail? > > Best Regards! > Arne Goetje (高盛華) > > > > From: FUJITA Tomonori <[email protected]> > To: [email protected], > Cc: [email protected] > Date: 04/15/2014 03:09 PM > Subject: Re: [Ryu-devel] [PATCH 1/3] sw test tool: Fix to compare > OFPMatch ignoring masks that are all one bits > > > > On Tue, 15 Apr 2014 14:52:39 +0900 > Yuichi Ito <[email protected]> wrote: > >> OF 1.3.3 spec (7.2.3.5 Flow Match Field Masking) says: >> >> An all-zero-bits oxm_mask is equivalent to omitting the OXM TLV > entirely. An all-one-bits oxm_mask >> is equivalent to specifying 0 for oxm_hasmask and omitting oxm_mask. >> >> This patch fixes to compare OFPMatch ignoring masks that are all one > bits. >> >> Reported-by: Arne Goetje <[email protected]> >> Signed-off-by: Yuichi Ito <[email protected]> >> --- >> ryu/tests/switch/tester.py | 21 +++++++++++++++++++++ >> 1 file changed, 21 insertions(+) > > Applied all, thanks! > > ------------------------------------------------------------------------------ > Learn Graph Databases - Download FREE O'Reilly Book > "Graph Databases" is the definitive new guide to graph databases and their > applications. Written by three acclaimed leaders in the field, > this first edition is now available. Download your free book today! > http://p.sf.net/sfu/NeoTech > _______________________________________________ > Ryu-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/ryu-devel > > > ------------------------------------------------------------------------------ > Learn Graph Databases - Download FREE O'Reilly Book > "Graph Databases" is the definitive new guide to graph databases and their > applications. Written by three acclaimed leaders in the field, > this first edition is now available. Download your free book today! > http://p.sf.net/sfu/NeoTech > _______________________________________________ > Ryu-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/ryu-devel > ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/NeoTech _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
