OpenFlow 1.2 section 6.7 describes inconsistent action in a flow as an action whose operation is inconsistent with the flows match.
In terms of the above the pop ttl action is considered inconsistent if it the flow does not match on a VLAN tag. This patch add such a match for the flow that has a pop VLAN action. I noticed this when using Open vSwitch's "make ryu-check" as Open vSwitch enforces action consistency for the pop VLAN TTL action. Signed-off-by: Simon Horman <[email protected]> --- ryu/tests/integrated/test_add_flow_v12_actions.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ryu/tests/integrated/test_add_flow_v12_actions.py b/ryu/tests/integrated/test_add_flow_v12_actions.py index 2f0c7f7..ad953c4 100644 --- a/ryu/tests/integrated/test_add_flow_v12_actions.py +++ b/ryu/tests/integrated/test_add_flow_v12_actions.py @@ -128,7 +128,9 @@ class RunTest(tester.TestFlowBase): self._verify = [dp.ofproto.OFPAT_POP_VLAN, ] actions = [dp.ofproto_parser.OFPActionPopVlan(), ] - self.add_apply_actions(dp, actions) + match = dp.ofproto_parser.OFPMatch() + match.set_vlan_vid(1) + self.add_apply_actions(dp, actions, match) def test_action_push_mpls(self, dp): ethertype = ether.ETH_TYPE_MPLS -- 1.8.5.2 ------------------------------------------------------------------------------ Start Your Social Network Today - Download eXo Platform Build your Enterprise Intranet with eXo Platform Software Java Based Open Source Intranet - Social, Extensible, Cloud Ready Get Started Now And Turn Your Intranet Into A Collaboration Platform http://p.sf.net/sfu/ExoPlatform _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
