2014-05-14 13:27 GMT+09:00 FUJITA Tomonori <[email protected]>: > On Tue, 13 May 2014 19:05:33 +0900 > Yoshihiro Kaneko <[email protected]> wrote: > >> Add the pep8 section to tox.ini and specify ignoring E113. >> Many E113 errors appeared on comments. It seems a bug of pep8, so it can be >> ignored. >> >> Signed-off-by: Yoshihiro Kaneko <[email protected]> >> --- >> run_tests.sh | 3 +-- >> tox.ini | 4 ++++ >> 2 files changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/run_tests.sh b/run_tests.sh >> index c48c069..1ab8aea 100755 >> --- a/run_tests.sh >> +++ b/run_tests.sh >> @@ -106,8 +106,7 @@ run_pylint() { >> run_pep8() { >> echo "Running pep8 ..." >> >> - PEP8_EXCLUDE="vcsversion.py,*.pyc,contrib,dictconfig.py" >> - PEP8_OPTIONS="--exclude=$PEP8_EXCLUDE --repeat --show-source" >> + PEP8_OPTIONS="--repeat --show-source" > > Hmm, why? With this patch, './run_tests.sh -p' gives more warnings.
I moved "exclude" option in tox.ini. If there is not "[pep8]" section in tox.ini, many errors will be appeared. Could you check your tox.ini? > > I've applied the other pep8 fix patches. Lots of warnings have gone, > but there are still some. Please check out. $ pep8 --version 1.5.6 $ ./run_tests.sh -p Running pep8 ... ryu/app/rest_qos.py:46:1: E265 block comment should start with '# ' #============================= ^ ryu/app/rest_qos.py:48:1: E265 block comment should start with '# ' #============================= ^ $ This module is newer than my work space. I'll post a patch for this shortly. Thanks > > Thanks a lot! ------------------------------------------------------------------------------ "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available Simple to use. Nothing to install. Get started now for free." http://p.sf.net/sfu/SauceLabs _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
