IMHO, OFPVID_PRESENT would be set in ofp_packet_in message if the packet had vlan tags.
I agree that it is hard to make sure that the implement is compliant. The description in the spec is as following: "The match field is a set of OXM TLVs containing the pipeline fields associated with a packet" For example, think the case of inserting a flow entry that "Match a packet that is UNTAG". Then the flow rule will have 0x0000/0x1000 oxm field. And when a packet maches this rule, the same in ofp_packet_in message we'd expect. Without OFPVID_PRESENT bit, we would not be able to distinguish the packet was TAGGED or not. (2014/07/07 15:35), Szymon Mentel wrote: > Hello Ryu users! > > I'm a developer of an OpenFlow switch LINC [1]. Recently I've came across an > issue from one of our users on VLAN_VID match field [2]. He suggests that > LINC behaves incorrectly while not setting the 13th bit in the value of the > match field that is sent in a packet_in message to the controller. In that > case LINC would have to set the value to 0x1**** (where **** is the VLAN ID) > when a VLAN tag is matched. > > On the other hand, I believe that LINC is compliant with the spec. If a > switch sends packet_in with a match on VLAN it's obvious that the VLAN tag > was indeed present in the packet and this information doesn't have to be > carried in an additional bit. If the VLAN is not present the match field for > VLAN is simply omitted in the packet_in. > > What is your opinion on this topic? > > Any answer that confirms or rejects any approach will be appreciated. > > [1]: https://github.com/FlowForwarding/LINC-Switch/ > [2]: https://github.com/FlowForwarding/LINC-Switch/issues/328 > > Regards, > > -- > Szymon Mentel > Erlang Solutions Ltd. > > ------------------------------------------------------------------------------ > Open source business process management suite built on Java and Eclipse > Turn processes into business applications with Bonita BPM Community Edition > Quickly connect people, data, and systems into organized workflows > Winner of BOSSIE, CODIE, OW2 and Gartner awards > http://p.sf.net/sfu/Bonitasoft > _______________________________________________ > Ryu-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/ryu-devel > ------------------------------------------------------------------------------ Open source business process management suite built on Java and Eclipse Turn processes into business applications with Bonita BPM Community Edition Quickly connect people, data, and systems into organized workflows Winner of BOSSIE, CODIE, OW2 and Gartner awards http://p.sf.net/sfu/Bonitasoft _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
