On Tue, 15 Jul 2014 16:51:21 +0900 Hiroshi Yokoi <[email protected]> wrote:
> added out-filter function to Ryu BGPSpeaker. > It supports IPv4 and IPv6. > > Signed-off-by: Hiroshi Yokoi <[email protected]> > --- > doc/source/library_bgp_speaker_ref.rst | 3 + > ryu/services/protocols/bgp/api/rtconf.py | 7 + > ryu/services/protocols/bgp/bgpspeaker.py | 189 > +++++++++++++++++++++++++ > ryu/services/protocols/bgp/info_base/base.py | 11 ++ > ryu/services/protocols/bgp/peer.py | 72 +++++++++- > ryu/services/protocols/bgp/rtconf/base.py | 3 + > ryu/services/protocols/bgp/rtconf/neighbors.py | 32 ++++- > 7 files changed, 310 insertions(+), 7 deletions(-) looks ok but can you fix the following pep8 warnings? Running pep8 ... ryu/services/protocols/bgp/bgpspeaker.py:96:80: E501 line too long (80 > 79 characters) * prefix_list = PrefixList('10.5.111.0/24', policy=PrefixList.POLICY_PERMIT) ^ ryu/services/protocols/bgp/bgpspeaker.py:112:80: E501 line too long (82 > 79 characters) * p = PrefixList('10.5.111.0/24', policy=PrefixList.POLICY_DENY, ge=26, le=28) ^ ryu/services/protocols/bgp/bgpspeaker.py:123:80: E501 line too long (83 > 79 characters) * p = PrefixList('10.5.111.0/24', policy=PrefixList.POLICY_DENY, ge=26, le=28). ^ ryu/services/protocols/bgp/bgpspeaker.py:456:80: E501 line too long (81 > 79 characters) ``prefix_lists`` specifies prefix list to filter route for advertisement. ^ ryu/services/protocols/bgp/bgpspeaker.py:464:80: E501 line too long (88 > 79 characters) If you want to define out-filter that send only a particular prefix to neighbor, ^ ryu/services/protocols/bgp/bgpspeaker.py:510:36: W292 no newline at end of file return settings[OUT_FILTER] ^ ryu/services/protocols/bgp/peer.py:118:1: E302 expected 2 blank lines, found 1 class PeerState(object): ^ ryu/services/protocols/bgp/peer.py:327:5: E303 too many blank lines (2) @property ^ ryu/services/protocols/bgp/peer.py:450:80: E501 line too long (85 > 79 characters) table = self._core_service.table_manager.get_global_table_by_route_family(rf) ^ ryu/services/protocols/bgp/peer.py:476:80: E501 line too long (82 > 79 characters) LOG.debug('send withdraw %s because of out filter' % nlri_str) ^ ryu/services/protocols/bgp/peer.py:478:80: E501 line too long (91 > 79 characters) outgoing_route = OutgoingRoute(sent_route.path, for_route_refresh=True) ^ ryu/services/protocols/bgp/peer.py:553:80: E501 line too long (87 > 79 characters) LOG.debug('prefix : %s is not sent by filter : %s' % (nlri, blocked_cause)) ^ ryu/services/protocols/bgp/api/rtconf.py:93:1: E302 expected 2 blank lines, found 1 def _update_outfilter(neigh_ip_address, value): ^ ryu/services/protocols/bgp/api/rtconf.py:98:1: E302 expected 2 blank lines, found 1 @RegisterWithArgChecks(name='neighbor.delete', ^ ryu/services/protocols/bgp/info_base/base.py:647:1: E302 expected 2 blank lines, found 1 class Path(object): ^ ryu/services/protocols/bgp/rtconf/neighbors.py:176:80: E501 line too long (86 > 79 characters) VALID_EVT = frozenset([UPDATE_ENABLED_EVT, UPDATE_MED_EVT, UPDATE_OUT_FILTER_EVT]) ^ ryu/services/protocols/bgp/rtconf/neighbors.py:555:1: E302 expected 2 blank lines, found 1 class NeighborsConfListener(BaseConfListener): ^ ------------------------------------------------------------------------------ Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
