On Fri, 18 Jul 2014 20:27:02 +0900 Hiroshi Yokoi <[email protected]> wrote:
> > Thank you for comments and code. > > As you mentioned, I should use "set" for comparing BGP capabilities > to simplify the code. > > But in order to use it, it is neccesary to override __hash__ and __cmp__ > method > at BGPOptParamCapabilityEnhancedRouteRefresh class or the parent class. > > So I implemented __hash__ and __cmp__ at _OptParamCapability class on trial > and I'm testing now. > Currently it seems to work without errors, > but I'm not sure that there is no side effect associated with this override. > > I am going to investigate codes that are using BGP capability classes. Ah, I've pushed your original patch. I still think that it's useful to have a helper function to compare the capability though. ------------------------------------------------------------------------------ Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
