On Fri, Sep 26, 2014 at 03:58:02PM +0900, Yusuke Iwase wrote: > In OF1.2 and OF1.3 Spec, the group type need not be specified > for the group delete request. > However, an error occurs at mod_group_entry in ofctl_v1_[23].py > without specifying group type to delete a group entry. > > This patch adds default value to type field of OFPGroupMod > at mod_group_entry in order to reflect OpenFlow Specification. > > Signed-off-by: IWASE Yusuke <[email protected]>
Reviewed-by: Simon Horman <[email protected]> > --- > ryu/lib/ofctl_v1_2.py | 2 +- > ryu/lib/ofctl_v1_3.py | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ryu/lib/ofctl_v1_2.py b/ryu/lib/ofctl_v1_2.py > index da300f7..21a3e34 100644 > --- a/ryu/lib/ofctl_v1_2.py > +++ b/ryu/lib/ofctl_v1_2.py > @@ -822,7 +822,7 @@ def mod_group_entry(dp, group, cmd): > 'INDIRECT': dp.ofproto.OFPGT_INDIRECT, > 'FF': dp.ofproto.OFPGT_FF} > > - type_ = type_convert.get(group.get('type')) > + type_ = type_convert.get(group.get('type', 'ALL')) > if type_ is None: > LOG.debug('Unknown type: %s', group.get('type')) > > diff --git a/ryu/lib/ofctl_v1_3.py b/ryu/lib/ofctl_v1_3.py > index b60c4cc..1167324 100644 > --- a/ryu/lib/ofctl_v1_3.py > +++ b/ryu/lib/ofctl_v1_3.py > @@ -1002,7 +1002,7 @@ def mod_group_entry(dp, group, cmd): > 'INDIRECT': dp.ofproto.OFPGT_INDIRECT, > 'FF': dp.ofproto.OFPGT_FF} > > - type_ = type_convert.get(group.get('type')) > + type_ = type_convert.get(group.get('type', 'ALL')) > if type_ is None: > LOG.debug('Unknown type: %s', group.get('type')) > > -- > 1.9.1 > > > ------------------------------------------------------------------------------ > Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer > Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports > Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper > Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer > http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk > _______________________________________________ > Ryu-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/ryu-devel > ------------------------------------------------------------------------------ Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
