On Sat, 11 Oct 2014 16:44:42 +0900 (JST) FUJITA Tomonori <[email protected]> wrote:
> On Fri, 10 Oct 2014 23:18:36 +0900 > Toshiki Tsuboi <[email protected]> wrote: > >> In generally, iBGP session is established between loopback interfaces. >> Therefore, we need to specify loopback interface as neighbour_source_address. >> This parameter is just like update-source command in cisco router. >> >> Signed-off-by: Toshiki Tsuboi <[email protected]> >> --- >> ryu/services/protocols/bgp/bgpspeaker.py | 16 +++++++++++++++- >> ryu/services/protocols/bgp/peer.py | 7 ++++++- >> 2 files changed, 21 insertions(+), 2 deletions(-) > > Applied, thanks. Applied the following to silence pep8 warnings. >From 9bfba7fd541f9ba6211c34e0e79a3b26cac9d389 Mon Sep 17 00:00:00 2001 From: FUJITA Tomonori <[email protected]> Date: Sat, 11 Oct 2014 17:00:44 +0900 Subject: [PATCH] bgp: fix pep8 warnings Signed-off-by: FUJITA Tomonori <[email protected]> --- ryu/services/protocols/bgp/bgpspeaker.py | 3 ++- ryu/services/protocols/bgp/peer.py | 9 +++++---- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/ryu/services/protocols/bgp/bgpspeaker.py b/ryu/services/protocols/bgp/bgpspeaker.py index 70a5bc4..d727c72 100644 --- a/ryu/services/protocols/bgp/bgpspeaker.py +++ b/ryu/services/protocols/bgp/bgpspeaker.py @@ -224,7 +224,8 @@ class BGPSpeaker(object): ``is_next_hop_self`` specifies whether the BGP speaker announces its own ip address to iBGP neighbor or not as path's next_hop address. - ``local_address`` specifies Loopback interface address for iBGP peering. + ``local_address`` specifies Loopback interface address for + iBGP peering. ``local_port`` specifies source TCP port for iBGP peering. diff --git a/ryu/services/protocols/bgp/peer.py b/ryu/services/protocols/bgp/peer.py index 8c17a58..5f78b3a 100644 --- a/ryu/services/protocols/bgp/peer.py +++ b/ryu/services/protocols/bgp/peer.py @@ -1038,11 +1038,12 @@ class Peer(Source, Sink, NeighborConfListener, Activity): const.STD_BGP_SERVER_PORT_NUM) if bind_addr: - LOG.debug('%s trying to connect from %s to %s' - % (self, bind_addr, peer_address)) + LOG.debug('%s trying to connect from' + '%s to %s' % (self, bind_addr, + peer_address)) else: - LOG.debug('%s trying to connect to %s' - % (self, peer_address)) + LOG.debug('%s trying to connect to %s' % (self, + peer_address)) tcp_conn_timeout = self._common_conf.tcp_conn_timeout try: password = self._neigh_conf.password -- 1.9.3 (Apple Git-50) ------------------------------------------------------------------------------ Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer http://p.sf.net/sfu/Zoho _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
