Hi, > Thanks. Yeah, the default is 128 bytes. Unless an application > configures the value via OFPT_SET_CONFIG, the default is used.
I'll try to explicitly set that once again, but so far I was under the impression that this was already done by the following code. The ofproto.OFPCML_NO_BUFFER is 0xffff and therefore should instruct the switch to always send the full packet. If that is true (would be great if you could confirm my understanding) the implementation on my product appears to have a bug there. I'll review the behaviour if I set ofproto.OFPCML_MAX as part of some "SET_CONFIG" routine (and probably review what v1.3.1 specs request ...). > @set_ev_cls(ofp_event.EventOFPSwitchFeatures, CONFIG_DISPATCHER) > def switch_features_handler(self, ev): > datapath = ev.msg.datapath > ofproto = datapath.ofproto > parser = datapath.ofproto_parser > > match = parser.OFPMatch() > actions = [parser.OFPActionOutput(ofproto.OFPP_CONTROLLER, > ofproto.OFPCML_NO_BUFFER)] > self.add_flow(datapath, 0, match, actions) Thanks, Regards, Benny On Sun, Oct 26, 2014 at 11:54 AM, FUJITA Tomonori < [email protected]> wrote: > On Thu, 23 Oct 2014 21:40:04 +0200 > Benjamin Eggerstedt <[email protected]> wrote: > > >> Here is a fix. > > I can confirm that your fix works fine. Ryu no longer encounters an issue > > when the truncated LLDP packet gets in. > > Thank you! > > Applied, thanks for the confirmation. > > >> The maximu size of a packet that the switch sends to a controller is > >> 128 bytes? > > > > It is not that we couldn't send more from our OmniSwitch, but I guess our > > implementation follows the OF v1.3.1 specifications. > > > > Please let me cite the OpenFlow v1.3.1 spec for details: > > 6.1.2 Asynchronous // Page 26 of 128 > >> ... > >> If the packet-in event is configured to buffer packets and the switch > has > > sufficient memory to buffer them, the packet-in events contain only some > > fraction of the packet > >> header and a buffer ID to be used by a controller when it is ready for > > the switch to forward the packet. > >> ... > >> If the packet is buffered, the number of bytes of the original packet to > > include in the packet-in can be configured. By default, it is 128 bytes. > >> For packet-in generated by an output action in a flow entries or group > > bucket, it can be specified individually in the output action itself (see > > A.2.5), for other packet-in > >> it can be configured in the switch configuration (see A.3.2). > > > > I couldn't find any specifics on "control packets that are supposed to > be > > treated in a special way", please advise if there is an official > > documentation / recommendation that I could use to get back to my R&D > > colleagues. > > Thanks. Yeah, the default is 128 bytes. Unless an application > configures the value via OFPT_SET_CONFIG, the default is used. >
------------------------------------------------------------------------------
_______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
